Merged
Conversation
st0012
approved these changes
Jan 27, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
Yes it's something I missed. Sorry about that and thanks for the PR 🙌
Contributor
|
@sl0thentr0py FYI. And here is sentry-python's implementation. |
st0012
added a commit
that referenced
this pull request
Jan 27, 2022
lewispb
added a commit
to lewispb/sentry-ruby
that referenced
this pull request
Feb 1, 2022
* master: feat(performance): Sync activerecord and net-http span names (getsentry#1681) Register Sentry's ErrorSubscriber for Rails 7.0+ apps (getsentry#1705) Support serializing ActiveRecord job arguments in global id form (getsentry#1688) release: 5.0.2 Fix report_after_job_retries's decision logic (getsentry#1704) Followup of getsentry#1701 (getsentry#1703) Capture transaction tags (getsentry#1701)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the following code:
I was expecting Sentry to create a clickable tag within the Tag Details section here:
However - this doesn't currently work because the transaction's tags aren't shared here:
sentry-ruby/sentry-ruby/lib/sentry/client.rb
Line 105 in 16a1305
With this change applied the tags from the transaction are captured and it creates a clickable tag within Event Details -> Tag Details
I wondered if there might be a specific reason transaction tags aren't currently captured or might it be possible to introduce this change.
Please let me know your thoughts - thanks very much!