feat: add option to attach view hierarchy#1191
Merged
JoshuaMoelans merged 24 commits intomasterfrom Apr 3, 2025
Merged
Conversation
|
supervacuus
reviewed
Mar 27, 2025
supervacuus
reviewed
Mar 27, 2025
JoshuaMoelans
commented
Mar 27, 2025
JoshuaMoelans
commented
Mar 27, 2025
Collaborator
|
Just letting you know that I tried it out with GH-143 and it worked! Thanks! |
1 task
attachment/content_type for attachments
supervacuus
reviewed
Mar 31, 2025
JoshuaMoelans
added a commit
to getsentry/relay
that referenced
this pull request
Apr 1, 2025
Related to getsentry/sentry-native#1191 We want to infer the AttachmentType of any incoming attachment that is called `view-hierarchy.json`. This follows the file naming convention specified in [RFC#33](https://github.com/getsentry/rfcs/blob/main/text/0033-view-hierarchy.md). We can still match on the `field_name` because it'll be the same as the `file_name`.
# Conflicts: # CHANGELOG.md
JoshuaMoelans
commented
Apr 1, 2025
JoshuaMoelans
commented
Apr 1, 2025
6 tasks
supervacuus
reviewed
Apr 1, 2025
supervacuus
requested changes
Apr 1, 2025
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Looks largely good. I would only ask for a few simplifying steps after we closed the API surface and a test for crashpad.
supervacuus
reviewed
Apr 2, 2025
supervacuus
approved these changes
Apr 3, 2025
supervacuus
reviewed
Apr 3, 2025
1 task
This was referenced Apr 26, 2025
6 tasks
JoshuaMoelans
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Apr 30, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> supersedes #13191 [Relevant Vercel Preview](https://develop-docs-git-feat-nativeview-hierarchy-option.sentry.dev/sdk/platform-specifics/native-sdks/attachments/) ## DESCRIBE YOUR PR Related to the Native SDK changes in getsentry/sentry-native#1191 ; since these are not useful for everyday native SDK users, but mainly for downstream SDK developers, we document this in the develop-docs instead of the user docs. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> supersedes #13191 [Relevant Vercel Preview](https://develop-docs-git-feat-nativeview-hierarchy-option.sentry.dev/sdk/platform-specifics/native-sdks/attachments/) ## DESCRIBE YOUR PR Related to the Native SDK changes in getsentry/sentry-native#1191 ; since these are not useful for everyday native SDK users, but mainly for downstream SDK developers, we document this in the develop-docs instead of the user docs. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1188
view-hierarchy.jsonrelay#4624view-hierarchy.jsonor it won't work on Crashpad, linking to RFC#33 feat(native): add view hierarchy docs sentry-docs#13191