feat(server): Update multipart infer for view-hierarchy.json#4624
Merged
JoshuaMoelans merged 6 commits intomasterfrom Apr 1, 2025
Merged
feat(server): Update multipart infer for view-hierarchy.json#4624JoshuaMoelans merged 6 commits intomasterfrom
view-hierarchy.json#4624JoshuaMoelans merged 6 commits intomasterfrom
Conversation
7 tasks
JoshuaMoelans
commented
Mar 31, 2025
it is the same as the file_name, so we keep it consistent
Member
|
Please add a changelog entry, but other than that this looks good. |
iambriccardo
approved these changes
Apr 1, 2025
view-hierarchy.json
tobias-wilfert
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to getsentry/sentry-native#1191
We want to infer the AttachmentType of any incoming attachment that is called
view-hierarchy.json. This follows the file naming convention specified in RFC#33. We can still match on thefield_namebecause it'll be the same as thefile_name.