feat(astro): Add assets option to source maps upload options#9668
Merged
feat(astro): Add assets option to source maps upload options#9668
assets option to source maps upload options#9668Conversation
f68fb96 to
8f4b2d4
Compare
lforst
approved these changes
Nov 27, 2023
Contributor
lforst
left a comment
There was a problem hiding this comment.
No direct exporting of API 👌😄
Member
Author
Never again ;) |
Contributor
size-limit report 📦
|
This was referenced Nov 27, 2023
8f4b2d4 to
0a82e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
assetsoption to the Astro integration source maps upload options.It behaves just like the
assetsoption of the Vite plugin, taking a (array of) glob(s) and overriding thedefault values.
This came up in #9591 and I think it makes sense to give users with more advanced/custom setups the ability to
override our defaults.
Docs PR: getsentry/sentry-docs#8586