feat(astro): Document assets sourcemaps upload option#8586
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
assets sourcemaps upload option
shanamatthews
approved these changes
Nov 28, 2023
Contributor
shanamatthews
left a comment
There was a problem hiding this comment.
lgtm! Just a couple of small suggestions.
lforst
approved these changes
Nov 29, 2023
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR adds documentation for the new
assetsoption soon to be released in the AstroSDK. Functionality it's 1:1 on par with the Vite plugin assets option but we don't expose the
full Vite Plugin API in the Astro SDK; hence the dedicated documentation.
Only merge after getsentry/sentry-javascript#9668 is relased but otherwise ready to review