feat(profiling): Use OTEL powered node package#11239
Merged
AbhiPrasad merged 2 commits intodevelopfrom Mar 25, 2024
Merged
Conversation
s1gr1d
approved these changes
Mar 22, 2024
Contributor
size-limit report 📦
|
8c4e908 to
3424cbe
Compare
AbhiPrasad
added a commit
that referenced
this pull request
Mar 25, 2024
Building on top of #11239, this removes usage of `getCurrentHub` in `profiling-node` package by passing in the defined client into the function. This also removes the `createProfilingEventFromTransaction`, which was totally unused.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
ref getsentry#9956 This is another attempt at getsentry#11033 now that getsentry#11135 has merged in.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Building on top of getsentry#11239, this removes usage of `getCurrentHub` in `profiling-node` package by passing in the defined client into the function. This also removes the `createProfilingEventFromTransaction`, which was totally unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #9956
This is another attempt at #11033 now that #11135 has merged in.