Skip to content

ref(profiling-node): Remove usage of getCurrentHub#11275

Merged
AbhiPrasad merged 1 commit intodevelopfrom
abhi-profiling-getCurrentHub
Mar 25, 2024
Merged

ref(profiling-node): Remove usage of getCurrentHub#11275
AbhiPrasad merged 1 commit intodevelopfrom
abhi-profiling-getCurrentHub

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

Building on top of #11239, this removes usage of getCurrentHub in profiling-node package by passing in the defined client into the function.

This also removes the createProfilingEventFromTransaction, which was totally unused.

@AbhiPrasad AbhiPrasad requested review from JonasBa and mydea March 25, 2024 18:47
@AbhiPrasad AbhiPrasad self-assigned this Mar 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.78 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.13 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.93 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.68 KB (added)
@sentry/browser (incl. Tracing) 36.73 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.73 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.44 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (added)
@sentry/browser (incl. sendFeedback) 27.4 KB (added)
@sentry/browser 22.56 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.12 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.94 KB (added)
CDN Bundle (incl. Tracing) 36.32 KB (added)
CDN Bundle 23.92 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.73 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.68 KB (added)
CDN Bundle - uncompressed 70.88 KB (added)
@sentry/react (incl. Tracing, Replay) 72.1 KB (added)
@sentry/react 22.59 KB (added)

@AbhiPrasad AbhiPrasad merged commit b7a50d6 into develop Mar 25, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-profiling-getCurrentHub branch March 25, 2024 21:01
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Building on top of
getsentry#11239, this removes
usage of `getCurrentHub` in `profiling-node` package by passing in the
defined client into the function.

This also removes the `createProfilingEventFromTransaction`, which was
totally unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants