feat(react): Add reactRouterV4/V5BrowserTracingIntegration for react router v4 & v5#10488
Merged
feat(react): Add reactRouterV4/V5BrowserTracingIntegration for react router v4 & v5#10488
reactRouterV4/V5BrowserTracingIntegration for react router v4 & v5#10488Conversation
This adds new `browserTracingReactRouterV4Integration()` and `browserTracingReactRouterV5Integration()` exports, deprecating these old routing instrumentations. I opted to leave as much as possible as-is for now, except for streamlining the attributes/tags we use for the instrumentation.
Contributor
size-limit report 📦
|
browserTracingIntegration for react router v4 & v5
lforst
approved these changes
Feb 5, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
Lgtm! Cleaning this stuff up is gonna be hella satisfying.
packages/react/src/index.ts
Outdated
Comment on lines
+15
to
+16
| browserTracingReactRouterV4Integration, | ||
| browserTracingReactRouterV5Integration, |
Contributor
There was a problem hiding this comment.
Idk if this makes sense but reactRouterV5BrowserTracingIntegration would sound better to me. Any reason you chose this order? ^^
lforst
approved these changes
Feb 5, 2024
…owserTracingIntegration`
browserTracingIntegration for react router v4 & v5reactRouterV4/V5BrowserTracingIntegration for react router v4 & v5
AbhiPrasad
approved these changes
Feb 5, 2024
| } | ||
| /* eslint-enable @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access */ | ||
|
|
||
| function getActiveRootSpan(): Span | undefined { |
Contributor
There was a problem hiding this comment.
might be worth lifting this utility out
Member
Author
There was a problem hiding this comment.
yeah, but here it's a bit special because it also takes the activeTransaction into consideration!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds new
reactRouterV4BrowserTracingIntegration()andreactRouterV5BrowserTracingIntegration()exports, deprecating these old routing instrumentations.I opted to leave as much as possible as-is for now, except for streamlining the attributes/tags we use for the instrumentation.
Tests lifted from #10430