feat(react): Add reactRouterV3BrowserTracingIntegration for react router v3#10489
Merged
feat(react): Add reactRouterV3BrowserTracingIntegration for react router v3#10489
reactRouterV3BrowserTracingIntegration for react router v3#10489Conversation
edbe9c2 to
7e3c69a
Compare
browserTracingReactRouterV3IntegrationbrowserTracingReactRouterV3Integration for react router v3
lforst
approved these changes
Feb 5, 2024
packages/react/src/index.ts
Outdated
| export { | ||
| // eslint-disable-next-line deprecation/deprecation | ||
| reactRouterV3Instrumentation, | ||
| browserTracingReactRouterV3Integration, |
Contributor
There was a problem hiding this comment.
Same as in #10488, reactRouterV3BrowserTracingIntegration would sound a bit cleaner to me.
7e3c69a to
727ae24
Compare
browserTracingReactRouterV3Integration for react router v3reactRouterV3BrowserTracingIntegration for react router v3
AbhiPrasad
approved these changes
Feb 5, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
IMHO that's acceptable, we don't really have a from field anyhow in other instrumentations, so we may even think about removing this I'd say
Let's remove
To replace the routing instrumentation.
727ae24 to
4bca46a
Compare
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To replace the routing instrumentation.
There is a small issue here, which is that we do not set the
fromattribute for the first navigation after the pageload (as technically we are calling instrument twice there...) - IMHO that's acceptable, we don't really have afromfield anyhow in other instrumentations, so we may even think about removing this I'd say...