Skip to content

Add data from transaction root span to contexts.trace.data#3735

Merged
adinauer merged 8 commits into8.x.xfrom
feat/transaction-data-in-trace-context-v8
Oct 15, 2024
Merged

Add data from transaction root span to contexts.trace.data#3735
adinauer merged 8 commits into8.x.xfrom
feat/transaction-data-in-trace-context-v8

Conversation

@lbloder
Copy link
Copy Markdown
Collaborator

@lbloder lbloder commented Sep 30, 2024

📜 Description

Supersedes #3642

💡 Motivation and Context

New PR to target 8.x branch
Fixes #3626

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 44e3c4c

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 30, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.94 ms 421.04 ms 52.10 ms
Size 1.70 MiB 2.35 MiB 664.53 KiB

Previous results on branch: feat/transaction-data-in-trace-context-v8

Startup times

Revision Plain With Sentry Diff
0a6d359 502.30 ms 580.29 ms 77.98 ms
33c2401 445.68 ms 447.53 ms 1.85 ms

App size

Revision Plain With Sentry Diff
0a6d359 1.70 MiB 2.35 MiB 669.13 KiB
33c2401 1.70 MiB 2.35 MiB 669.13 KiB

@lbloder lbloder changed the title Add data from transaction root span to trace.context.data Add data from transaction root span to contexts.trace.data Oct 1, 2024
@lbloder lbloder marked this pull request as ready for review October 1, 2024 07:58
Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants