Add data from transaction root span to trace.context.data#3642
Closed
Add data from transaction root span to trace.context.data#3642
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
stefanosiano
reviewed
Sep 2, 2024
| } | ||
|
|
||
| final Map<String, Object> data = sentryTracer.getData(); | ||
| // TODO should we remove setExtra here, or do we need it for backwards compat? |
Collaborator
Author
There was a problem hiding this comment.
@stefanosiano as per the latest discussion here I'll remove it
Collaborator
Author
There was a problem hiding this comment.
@stefanosiano still in some discussions about this :) as both not setting the data in extras as well as adding data to trace.context.data might result in breaking changes for users
Collaborator
Author
There was a problem hiding this comment.
Closing this for now, created a PR that targets 8.x which removes this (as both keeping and removing this would constitute a breaking change).
7 tasks
Collaborator
Author
|
Closed in favor of #3735 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add root span data to
traceContextwhenSentryTransactionis created💡 Motivation and Context
Fixes #3626
💚 How did you test it?
Modified existing serialization tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps