feat!: remove SetExtra#1274
Merged
Merged
Conversation
This changes the behavior of stripping the event when serialization fails and resending, with just sending a client report when serialization fails
Semver Impact of This PR🔴 Major (breaking changes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
New Features ✨
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2d76cc3. Configure here.
This was referenced Apr 21, 2026
8 tasks
1 task
denniszag
added a commit
to denniszag/errors
that referenced
this pull request
Apr 25, 2026
sentry-go v0.46.0 removed the Extra field from sentry.Event (see getsentry/sentry-go#1274). ReportError merged its extraDetails map into event.Extra, which now fails to compile against sentry-go >= v0.46.0. Because report_api.go in the root errors package imports the report sub-package, the typecheck failure blocks the entire module for every downstream consumer -- not just callers of the Sentry reporting code. Switches the per-key merge to event.Contexts, which is the documented replacement. Each extra is stored under sentry.Context{"value": v} to conform to the Context schema (map[string]interface{}). Along the way: - Adds the new Close() and FlushWithContext(ctx) methods required by the v0.46.0 sentry.Transport interface on the test-only interceptingTransport in report/report_test.go and fmttests/datadriven_test.go. - In the fmttests printer, filters to only Contexts entries that carry our "value" sub-key, so Sentry's built-in default contexts (device/os/runtime/trace) emitted by sentry.NewEvent() do not leak into fixtures. Preserves the "== Extra" label -- net fixture diff is empty. - Fixes a pre-existing non-constant-format-string call in fmttests/datadriven_test.go flagged by the stricter go vet in the Go toolchain now required by sentry-go v0.46.0. - Bumps the go directive to 1.25.0 (drops the no-longer-needed toolchain line) because sentry-go v0.46.0 itself declares go 1.25.0. Fixes cockroachdb#158
5 tasks
jeremyames-gmail
added a commit
to festion/birdnet-gone
that referenced
this pull request
May 10, 2026
* chore(deps): bump getsentry/sentry-go to v0.46.2 Breaking: removes Event.Extra and Scope.SetExtra (upstream sentry-go#1274). Subsequent commit ports internal/telemetry to Tags-based API. Build is intentionally broken on this commit -- see docs/plans/2026-05-10-sentry-go-extra-migration.md. Refs: #70 (closed group bump that included this version), Vikunja #1139. * refactor(telemetry): port to sentry-go v0.46 Tags API sentry-go v0.46 (PR getsentry/sentry-go#1274) removed Event.Extra and Scope.SetExtra. Migrate the one writer (CaptureError's error_type field) to SetTag -- error_type is already a string label, so SetTag is the natural target. Strip Extra-handling from the privacy filter (applyPrivacyFilters, applyPrivacyFiltersWithLogging, and the now- unused removePrivacyExtraFields helper). Remove the Extra column from EventSummary and update telemetry_test.go to round-trip via Tags. The privacy filter retains the same structural behavior for Tags and Contexts (no changes to which keys are stripped). error_type as a Tag is non-PII (it's a parsed runtime error category, e.g. 'Nil Pointer Dereference', generated by parseErrorType from the *scrubbed* message -- see sentry.go::parseErrorType + privacy.ScrubMessage). Refs: Vikunja #1139, #70 (closed group bump that included this version). --------- Co-authored-by: festion <festion@users.noreply.github.com>
AndrewHart102
added a commit
to scribd/go-sdk
that referenced
this pull request
May 14, 2026
v0.46.0 removed Event.Extra (getsentry/sentry-go#1274). Migrate the logrus hook to populate Event.Contexts under a "logrus" key, matching the official migration path for arbitrary structured data on error events. entry.Data fields now appear under a Logrus context section in the Sentry UI instead of the legacy Additional Data section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR removes deprecated
SetExtraand update the code to eitherSetTagorSetAttributeinstead.Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)