Skip to content

refactor(telemetry): port to sentry-go v0.46 Tags API#85

Merged
jeremyames-gmail merged 2 commits into
mainfrom
sentry-go-extra-migration
May 10, 2026
Merged

refactor(telemetry): port to sentry-go v0.46 Tags API#85
jeremyames-gmail merged 2 commits into
mainfrom
sentry-go-extra-migration

Conversation

@jeremyames-gmail

Copy link
Copy Markdown
Contributor

Summary

  • Bumps getsentry/sentry-go 0.42.0 → 0.46.2
  • Migrates the one scope.SetExtra writer in CaptureError to SetTag (the value is already a string)
  • Strips Event.Extra references from the privacy filter and EventSummary mock — Extra was removed from sentry-go in upstream PR feat!: remove SetExtra getsentry/sentry-go#1274
  • Updates TestEventSummaries (telemetry_test.go) to round-trip via Tags

Test plan

  • go test ./internal/telemetry/ -race -count=1 passes
  • task lint clean (0 issues across 29 active linters)
  • Whole project compiles
  • No remaining event.Extra / SetExtra references in internal/
  • CI green

Notes

  • error_type was rendered under "Additional Data" in Sentry; it now appears under "Tags". Same data, different UI section.
  • error_type is a parsed runtime category (e.g. "Nil Pointer Dereference") generated by parseErrorType from the scrubbed message, so no PII path that wasn't already there.
  • Fingerprinting via scope.SetFingerprint is unchanged.

Background

PR #70 (the dependabot go-minor-patch group bump) was closed because it bundled this breaking sentry-go upgrade with 15 unrelated bumps. After this lands, dependabot will re-raise the remaining 15 as a clean group.

Refs: Vikunja #1139, plan at docs/plans/2026-05-10-sentry-go-extra-migration.md

🤖 Generated with Claude Code

festion added 2 commits May 10, 2026 11:50
Breaking: removes Event.Extra and Scope.SetExtra (upstream
sentry-go#1274). Subsequent commit ports internal/telemetry
to Tags-based API. Build is intentionally broken on this
commit -- see docs/plans/2026-05-10-sentry-go-extra-migration.md.

Refs: #70 (closed group bump that included
this version), Vikunja #1139.
sentry-go v0.46 (PR getsentry/sentry-go#1274) removed Event.Extra
and Scope.SetExtra. Migrate the one writer (CaptureError's error_type
field) to SetTag -- error_type is already a string label, so SetTag
is the natural target. Strip Extra-handling from the privacy filter
(applyPrivacyFilters, applyPrivacyFiltersWithLogging, and the now-
unused removePrivacyExtraFields helper). Remove the Extra column
from EventSummary and update telemetry_test.go to round-trip via Tags.

The privacy filter retains the same structural behavior for Tags
and Contexts (no changes to which keys are stripped). error_type as
a Tag is non-PII (it's a parsed runtime error category, e.g. 'Nil
Pointer Dereference', generated by parseErrorType from the *scrubbed*
message -- see sentry.go::parseErrorType + privacy.ScrubMessage).

Refs: Vikunja #1139, #70 (closed group bump
that included this version).
@jeremyames-gmail jeremyames-gmail merged commit b14e7d4 into main May 10, 2026
5 checks passed
@jeremyames-gmail jeremyames-gmail deleted the sentry-go-extra-migration branch May 10, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant