Java: Connecting Errors with Spans#2818
Java: Connecting Errors with Spans#2818maciejwalkowiak wants to merge 6 commits intogetsentry:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/4mxpseo8b/sentry.dev |
bruno-garcia
left a comment
There was a problem hiding this comment.
Seems like my comments where not sent, sorry
|
Docs adjusted to changes made in PR: getsentry/sentry-java#1156 |
PeloWriter
left a comment
There was a problem hiding this comment.
Couple of changes (one of which is an edit that I think captures what we mean to explain, but please review to ensure it doesn't change the meaning)
| } | ||
| ``` | ||
|
|
||
| Please note, that in Spring Boot integration, errors are linked with spans automatically and there is no need to follow these steps. |
There was a problem hiding this comment.
Move this up earlier in the page so Spring Boot users don't get to the end, only to learn they didn't need to read this far :).
| Please note, that in Spring Boot integration, errors are linked with spans automatically and there is no need to follow these steps. | |
| <Note> | |
| In our Spring Boot integration, errors are linked with spans automatically. | |
| </Note> |
| } | ||
| ``` | ||
|
|
||
| Please note, that in Spring Boot integration, errors are linked with spans automatically and there is no need to follow these steps. |
There was a problem hiding this comment.
Isn't it "on our Spring Integration"?
Is this exclusive to Spring Boot? We've got customers asking for this that use Spring but not Spring Boot.
There was a problem hiding this comment.
Correct, updated.
bruno-garcia
left a comment
There was a problem hiding this comment.
Small note on Spring Boot vs Spring but other than that LGTM
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
Co-authored-by: Fiona <61481573+PeloWriter@users.noreply.github.com>
|
Since these changes can be merged after next 4.0 is released, I moved changes from this PR to #2833. |
Related to getsentry/sentry-dotnet#663 (comment)