Automatically assign span context to captured events.#1156
Merged
maciejwalkowiak merged 4 commits intomainfrom Jan 12, 2021
Merged
Automatically assign span context to captured events.#1156maciejwalkowiak merged 4 commits intomainfrom
maciejwalkowiak merged 4 commits intomainfrom
Conversation
| private void assignTraceContext(final @NotNull SentryEvent event) { | ||
| if (event.getThrowable() != null) { | ||
| final SpanContext spanContext = throwableToSpanContext.get(event.getThrowable()); | ||
| if (spanContext != null && event.getContexts().getTrace() == null) { |
Member
There was a problem hiding this comment.
If these have public setters and are nullable we should navigate through considering they might be.
Member
|
Could you please attach a screenshot of what the issue event look like having that context attached to it? |
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
============================================
+ Coverage 75.31% 75.33% +0.02%
- Complexity 1645 1649 +4
============================================
Files 169 169
Lines 5696 5705 +9
Branches 557 559 +2
============================================
+ Hits 4290 4298 +8
- Misses 1150 1151 +1
Partials 256 256
Continue to review full report at Codecov.
|
Contributor
Author
|
I do not know why in event trace details are also shown on the righthand side in tags and in other they are not. |
bruno-garcia
approved these changes
Jan 12, 2021
This was referenced Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Automatically assign span context to captured events.
💡 Motivation and Context
One step less for users using manual performance reporting.
Result of the discussion: https://github.com/getsentry/sentry-docs/pull/2818/files#r551077018
💚 How did you test it?
Unit & Integration tests.
📝 Checklist
🔮 Next steps