Skip to content

Send Less Client Reports When Rate Limited #2380

Merged
buenaflor merged 12 commits into
mainfrom
enha/client-reports-rate-limiting
Nov 7, 2024
Merged

Send Less Client Reports When Rate Limited #2380
buenaflor merged 12 commits into
mainfrom
enha/client-reports-rate-limiting

Conversation

@denrase

@denrase denrase commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📜 Description

  • Add client reports after rate limit filtering.
  • Try to send client reports only after getting fully rate limited 10 times.

💡 Motivation and Context

Closes #2370

💚 How did you test it?

  • Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov

codecov Bot commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (4e534f9) to head (d601703).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...art/lib/src/transport/client_report_transport.dart 90.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2380   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files         253      254    +1     
  Lines        9097     9113   +16     
=======================================
+ Hits         7707     7721   +14     
- Misses       1390     1392    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.71 ms 527.84 ms 65.13 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1a93825 347.31 ms 424.54 ms 77.23 ms
a510d1d 295.63 ms 344.65 ms 49.03 ms
a7acb24 301.00 ms 357.38 ms 56.38 ms
6034b0a 406.35 ms 475.93 ms 69.59 ms
2d74010 400.42 ms 466.50 ms 66.08 ms
4b5a4f6 394.19 ms 471.81 ms 77.62 ms
bf8d36c 505.00 ms 563.18 ms 58.18 ms
e82709a 361.18 ms 423.50 ms 62.32 ms
c732386 316.84 ms 390.62 ms 73.78 ms
24f71aa 358.49 ms 455.90 ms 97.41 ms

App size

Revision Plain With Sentry Diff
1a93825 6.27 MiB 7.20 MiB 956.36 KiB
a510d1d 5.94 MiB 6.96 MiB 1.02 MiB
a7acb24 5.94 MiB 6.95 MiB 1.01 MiB
6034b0a 6.34 MiB 7.29 MiB 970.36 KiB
2d74010 6.33 MiB 7.26 MiB 943.41 KiB
4b5a4f6 6.34 MiB 7.28 MiB 962.57 KiB
bf8d36c 6.49 MiB 7.56 MiB 1.07 MiB
e82709a 6.34 MiB 7.29 MiB 970.37 KiB
c732386 6.26 MiB 7.20 MiB 958.78 KiB
24f71aa 6.06 MiB 7.03 MiB 990.30 KiB

Previous results on branch: enha/client-reports-rate-limiting

Startup times

Revision Plain With Sentry Diff
5977911 447.83 ms 485.13 ms 37.30 ms
c7f254c 462.83 ms 490.56 ms 27.73 ms
9a345d1 444.06 ms 482.57 ms 38.50 ms
860c2c8 445.57 ms 493.96 ms 48.39 ms

App size

Revision Plain With Sentry Diff
5977911 6.49 MiB 7.57 MiB 1.08 MiB
c7f254c 6.49 MiB 7.57 MiB 1.08 MiB
9a345d1 6.49 MiB 7.57 MiB 1.08 MiB
860c2c8 6.49 MiB 7.57 MiB 1.08 MiB

@github-actions

github-actions Bot commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.21 ms 1251.83 ms 21.62 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d4d0807 1246.94 ms 1260.69 ms 13.75 ms
f9d18f3 1240.20 ms 1242.78 ms 2.57 ms
04bd9e6 1230.78 ms 1250.71 ms 19.94 ms
051e97a 1245.94 ms 1249.51 ms 3.57 ms
b8562d0 1249.92 ms 1267.56 ms 17.64 ms
affcf07 1240.61 ms 1266.49 ms 25.88 ms
2e8b1e1 1247.45 ms 1263.67 ms 16.22 ms
0f067d3 1245.71 ms 1269.59 ms 23.88 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
e239c83 1248.40 ms 1269.28 ms 20.89 ms

App size

Revision Plain With Sentry Diff
d4d0807 8.33 MiB 9.64 MiB 1.31 MiB
f9d18f3 8.29 MiB 9.36 MiB 1.07 MiB
04bd9e6 8.33 MiB 9.61 MiB 1.27 MiB
051e97a 8.28 MiB 9.34 MiB 1.06 MiB
b8562d0 8.33 MiB 9.54 MiB 1.22 MiB
affcf07 8.38 MiB 9.70 MiB 1.33 MiB
2e8b1e1 8.33 MiB 9.64 MiB 1.31 MiB
0f067d3 8.32 MiB 9.52 MiB 1.20 MiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
e239c83 8.38 MiB 9.74 MiB 1.36 MiB

Previous results on branch: enha/client-reports-rate-limiting

Startup times

Revision Plain With Sentry Diff
9a345d1 1249.06 ms 1272.39 ms 23.33 ms
860c2c8 1260.31 ms 1288.85 ms 28.54 ms
5977911 1234.78 ms 1251.49 ms 16.71 ms
c7f254c 1245.04 ms 1274.59 ms 29.55 ms

App size

Revision Plain With Sentry Diff
9a345d1 8.38 MiB 9.75 MiB 1.37 MiB
860c2c8 8.38 MiB 9.75 MiB 1.37 MiB
5977911 8.38 MiB 9.75 MiB 1.37 MiB
c7f254c 8.38 MiB 9.75 MiB 1.37 MiB

@denrase denrase marked this pull request as ready for review October 30, 2024 15:17
buenaflor
buenaflor reviewed Oct 31, 2024
View reviewed changes
Comment thread dart/lib/src/transport/http_transport.dart Outdated
buenaflor
buenaflor reviewed Oct 31, 2024
View reviewed changes
Comment thread dart/lib/src/transport/client_report_transport.dart
@denrase denrase requested a review from buenaflor November 4, 2024 11:12
@buenaflor buenaflor merged commit bec58b2 into main Nov 7, 2024
@buenaflor buenaflor deleted the enha/client-reports-rate-limiting branch November 7, 2024 15:22
@github-actions

github-actions Bot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Send Less Client Reports When Rate Limited ([#2380](https://github.com/getsentry/sentry-dart/pull/2380))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d601703

martinhaintz added a commit that referenced this pull request Nov 11, 2024
@martinhaintz
Merge branch 'main' into feat/redact-screenshots-via-view-hierarchy
9699edc 
* main:
  release: 8.10.1
  fix: android build error when compiling (#2397)
  release: 8.10.0
  chore: prepare changelog for `8.10.0` release (#2391)
  chore(deps): update Cocoa SDK to v8.40.1 (#2394)
  fix: cocoa sdk version updater (#2392)
  Send Less Client Reports When Rate Limited (#2380)
  build(deps): bump ruby/setup-ruby from 1.197.0 to 1.199.0 (#2386)
  chore(deps): update Native SDK to v0.7.12 (#2390)
  chore(deps): update Android SDK to v7.16.0 (#2373)
  fix build error for latest flutter beta (3.27.0) (#2385)
  Remove duplicate tests in sentry_client_test.dart (#2378)
  Handle backpressure earlier in pipeline (#2371)
  Add screenshot to `SentryFeedbackWidget` (#2369)

# Conflicts:
#	flutter/lib/src/event_processor/screenshot_event_processor.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buenaflor buenaflor buenaflor approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@martinhaintz martinhaintz Awaiting requested review from martinhaintz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Send Less Client Reports When Rate Limited

2 participants

@denrase @buenaflor