Remove duplicate tests in sentry_client_test.dart#2378
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
+ Coverage 84.72% 85.64% +0.91%
==========================================
Files 253 240 -13
Lines 9083 8688 -395
==========================================
- Hits 7696 7441 -255
+ Misses 1387 1247 -140 ☔ View full report in Codecov by Sentry. |
buenaflor
approved these changes
Oct 29, 2024
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
lgtm, please check the coverage also to be sure
Collaborator
Author
|
@buenaflor Coverage should stay the same, as these were dupes. But lets wait for CI to finish. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
| 2966d88 | 1251.76 ms | 1270.21 ms | 18.46 ms |
| f172c4d | 1350.66 ms | 1408.49 ms | 57.83 ms |
| 0a23f98 | 1252.98 ms | 1276.76 ms | 23.78 ms |
| 6daa837 | 1250.42 ms | 1265.60 ms | 15.18 ms |
| f79eecf | 1210.25 ms | 1221.65 ms | 11.40 ms |
| 7954fb3 | 1247.20 ms | 1272.15 ms | 24.94 ms |
| 5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
| bf4aed7 | 1274.63 ms | 1286.48 ms | 11.85 ms |
| 24f71aa | 1267.47 ms | 1272.00 ms | 4.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
| 2966d88 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| f172c4d | 8.33 MiB | 9.62 MiB | 1.29 MiB |
| 0a23f98 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 6daa837 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| f79eecf | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 7954fb3 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| bf4aed7 | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| 24f71aa | 8.10 MiB | 9.16 MiB | 1.07 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a111a9 | 496.27 ms | 520.57 ms | 24.31 ms |
| 5f2f77b | 429.06 ms | 507.74 ms | 78.68 ms |
| 7ec9238 | 414.02 ms | 513.94 ms | 99.91 ms |
| abfcdb5 | 416.55 ms | 498.88 ms | 82.33 ms |
| 26e955b | 369.52 ms | 458.60 ms | 89.07 ms |
| 7f75f32 | 347.36 ms | 419.58 ms | 72.22 ms |
| 7d5e695 | 433.45 ms | 485.11 ms | 51.66 ms |
| cdf7172 | 348.54 ms | 390.81 ms | 42.27 ms |
| 5aba417 | 355.78 ms | 450.39 ms | 94.61 ms |
| 3334ac1 | 303.98 ms | 366.65 ms | 62.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a111a9 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 5f2f77b | 6.35 MiB | 7.40 MiB | 1.05 MiB |
| 7ec9238 | 6.35 MiB | 7.42 MiB | 1.06 MiB |
| abfcdb5 | 6.35 MiB | 7.40 MiB | 1.05 MiB |
| 26e955b | 6.27 MiB | 7.20 MiB | 956.49 KiB |
| 7f75f32 | 6.26 MiB | 7.20 MiB | 959.18 KiB |
| 7d5e695 | 6.49 MiB | 7.55 MiB | 1.07 MiB |
| cdf7172 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 5aba417 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 3334ac1 | 6.06 MiB | 7.03 MiB | 993.54 KiB |
martinhaintz
added a commit
that referenced
this pull request
Nov 11, 2024
* main: release: 8.10.1 fix: android build error when compiling (#2397) release: 8.10.0 chore: prepare changelog for `8.10.0` release (#2391) chore(deps): update Cocoa SDK to v8.40.1 (#2394) fix: cocoa sdk version updater (#2392) Send Less Client Reports When Rate Limited (#2380) build(deps): bump ruby/setup-ruby from 1.197.0 to 1.199.0 (#2386) chore(deps): update Native SDK to v0.7.12 (#2390) chore(deps): update Android SDK to v7.16.0 (#2373) fix build error for latest flutter beta (3.27.0) (#2385) Remove duplicate tests in sentry_client_test.dart (#2378) Handle backpressure earlier in pipeline (#2371) Add screenshot to `SentryFeedbackWidget` (#2369) # Conflicts: # flutter/lib/src/event_processor/screenshot_event_processor.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Remove duplicate tests in sentry_client_test.dart