🔧 chore(aci): update send_activity_notification to not send notifications for metric alert resolutions
#95476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for metric alert resolutions
GabeVillalobos
approved these changes
Jul 14, 2025
Member
GabeVillalobos
left a comment
There was a problem hiding this comment.
Changes seem reasonable
Comment on lines
+160
to
+163
| metric_resolved_notification = ( | ||
| activity.type == ActivityType.SET_RESOLVED.value | ||
| and activity.group.issue_type.type_id == MetricIssue.type_id | ||
| ) |
Member
There was a problem hiding this comment.
Future improvement -> Is this something that should be moved to the activity class, or some shared utils file for classifying metric notifications?
Collaborator
Author
There was a problem hiding this comment.
ideally we don't do this logic in the future imo
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 21, 2025
…ations for metric alert resolutions (#95476)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #95475
Once we build out the ability for the NOA to send Metric Issue Resolution notifications, we want to make sure we don't double notify and send an activity notification as well.
For slack, it is not powered by
activity.send_notificationrather a receiver on theActivitymodel, so I need to separate case it as well.I also updated the check from
group_categorytotype_idsince thegroup_categoryis mainly for the FE and can change.