🔧 chore(aci): pass evidence data to activity model for notifications #95475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajjoshi
commented
Jul 14, 2025
|
|
||
| def bulk_get_groups_from_fingerprints( | ||
| project_fingerprint_pairs: Iterable[tuple[int, Sequence[str]]] | ||
| project_fingerprint_pairs: Iterable[tuple[int, Sequence[str]]], |
Collaborator
Author
There was a problem hiding this comment.
linter changes
snigdhas
approved these changes
Jul 14, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95475 +/- ##
==========================================
- Coverage 86.44% 80.47% -5.97%
==========================================
Files 10535 10492 -43
Lines 607153 605697 -1456
Branches 23781 23781
==========================================
- Hits 524828 487449 -37379
- Misses 82031 117954 +35923
Partials 294 294 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work for https://www.notion.so/sentry/Workflow-Status-Changes-1fa8b10e4b5d80a48acddb95d160da1f?source=copy_link#1fa8b10e4b5d80e6bb1aef39cab2c6dc
Following up: #93522
This PR adds support for passing evidence data from workflow engine detectors to activity records when status changes occur.
fetch_evidence_dataactivity_datafield toStatusChangeMessageandStatusChangeMessageDataclassesA followup PR will use the data saved on the
Activityto send notifications.