feat(launchpad): Create size analysis upload (assemble) endpoint #94353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #94353 +/- ##
==========================================
+ Coverage 86.60% 87.93% +1.32%
==========================================
Files 10418 10418
Lines 602751 602894 +143
Branches 23451 23451
==========================================
+ Hits 522009 530131 +8122
+ Misses 80236 72257 -7979
Partials 506 506 |
41f69ae to
8e92148
Compare
3d2d7a5 to
d728ac7
Compare
NicoHinderling
commented
Jun 26, 2025
| def test_download_preprod_artifact_success(self): | ||
| url = f"/api/0/internal/{self.organization.slug}/{self.project.slug}/files/preprodartifacts/{self.preprod_artifact.id}/" | ||
|
|
||
| headers = self._get_authenticated_request_headers(url) |
Contributor
Author
There was a problem hiding this comment.
i accidentally had the feature flag included in these tests. just cleaning it out
trevor-e
approved these changes
Jun 26, 2025
| "organization_id": org_id, | ||
| }, | ||
| ) | ||
| set_assemble_status( |
Member
There was a problem hiding this comment.
Does this need to update the DB record to an error state?
Contributor
Author
There was a problem hiding this comment.
yes we should, good call. i'll add
Contributor
Author
There was a problem hiding this comment.
actually this case is pretty much only if you try to upload a size analysis file before there's a corresonding preprodartifact row in the DB, so I'm not going to update the DB in this case. I added logic into the "update" endpoint to ensure we have the logic required to mark the artifacts as failed w the corresponding errors
d728ac7 to
ea3f3b3
Compare
9472cf4 to
e997022
Compare
e997022 to
519edfc
Compare
519edfc to
3b07e6b
Compare
Base automatically changed from
06-25-feat_launchpad_create_preprocessing_update_endpoint
to
master
June 26, 2025 21:22
3b07e6b to
a892807
Compare
a892807 to
08275b7
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related project