feat(launchpad): Create preprocessing update endpoint #94352
Conversation
3d2d7a5 to
d728ac7
Compare
| "build_version": {"type": "string", "maxLength": 255}, | ||
| "build_number": {"type": "integer"}, | ||
| }, | ||
| "additionalProperties": False, |
There was a problem hiding this comment.
Does this mean it will fail if additional properties are sent? I think having validation for the fields that get passed through to the DB is fine, but should make sure we can send extra fields too like the treemap data.
There was a problem hiding this comment.
Looks like based on the test case we can't pass extra fields. I think we'll want to turn this True for now.
There was a problem hiding this comment.
Oh this is for the preprocessing endpoint 🤦
| "artifact_type": {"type": "integer", "minimum": 0, "maximum": 2}, | ||
| "error_message": {"type": "string"}, | ||
| "build_version": {"type": "string", "maxLength": 255}, | ||
| "build_number": {"type": "integer"}, |
There was a problem hiding this comment.
Can we add a few fields from AppleAppInfo here? https://github.com/getsentry/launchpad/blob/fa84c05b93d38c41a85b6783537dabbf50556f7a/src/launchpad/models/apple.py#L44 That's the type that we get on the processing side before calling this. Specifically these fields we need in preprocessing:
is_simulator: bool
codesigning_type: string
profile_name: string
is_code_signature_valid: bool
code_signature_errors: [string]
There was a problem hiding this comment.
Additional request - could we add this in a "sub" apple_app_info object that's nullable? Want to keep this separate from Android as much as possible.
There was a problem hiding this comment.
yes I'll do that ryan
d728ac7 to
ea3f3b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94352 +/- ##
==========================================
+ Coverage 78.08% 87.93% +9.84%
==========================================
Files 10377 10379 +2
Lines 601030 601247 +217
Branches 23393 23393
==========================================
+ Hits 469321 528699 +59378
+ Misses 131242 72081 -59161
Partials 467 467 |
related project