chore: Investigating org slug already set to a different value by armenzg · Pull Request #45134 · getsentry/sentry

armenzg · 2023-02-27T18:07:36Z

We have events tagged with the following info even when it is not possible:

org slug
org id
org context (see screenshot)

The only code that sets these three pieces of information is within the sdk.py module.

This change will report a Sentry error (it won't abort the execution of the code).

A sample event can be seen here (private link)

Here's a query showing some transactions that should not have these values set. There may be more transaction since I'm narrowing the query down to just error.value:"Integration matching query does not exist."

This fix helps investigate: WOR-2464

Screenshot showing org context being set:

armenzg · 2023-02-27T18:08:41Z

src/sentry/utils/sdk.py

+    from what we want to set it to.
+    """
+    with configure_scope() as scope:
+        if scope._tags and tag_key in scope._tags and scope._tags[tag_key] != expected_value:


The main difference with #45039 is that we also check for the tags being different ( scope._tags[tag_key] != expected_value).

armenzg · 2023-02-27T18:10:44Z

src/sentry/utils/sdk.py

+                "This is an intended error for investigating what is the root of this problem."
+            )
+    except Exception as e:
+        logger.exception(e)


The reason I create Sentry errors is because I get access to the logs.
It would be great if I could make expected errors not to show up as "red" like real errors.

It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context The only code that sets these three pieces of information is within the sdk.py module (see #45134 for details). This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. It is unclear if the root cause comes from a bug in the SDK or the way we tag things in our code base. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. A sample event can be seen [here](https://sentry.sentry.io/discover/sentry:99c8b9c9d2c241cc90e52c307faa45eb/?field=organization.slug&field=user.display&field=timestamp&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=issue%3ASENTRY-W7T&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29) (private link) Here's a [query](https://sentry.sentry.io/discover/results/?field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&statsPeriod=14d&yAxis=count%28%29) showing some transactions that should not have org values set. There may be more transaction since I'm narrowing the query down to just `error.value:"Integration matching query does not exist."` Improves [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464)

armenzg · 2023-02-27T21:02:33Z

src/sentry/utils/sdk.py

+            }
+            logger.warning(f"Tag already set and different ({tag_key}).", extra=extra)
+            # This can be used to find errors that may have been mistagged
+            scope.set_tag("possible_mistag", True)


This is what I believe would help most.

armenzg · 2023-02-27T21:14:28Z

I will investigate if the errors are real tomorrow. I will also deploy it if not.

getsentry-bot · 2023-02-28T15:25:52Z

PR reverted: fb648cc

#45134)" This reverts commit 76a4d84. Co-authored-by: armenzg <44410+armenzg@users.noreply.github.com>

armenzg · 2023-02-28T16:12:32Z

I reverted because it produced too many errors. It proves the point that it is happening and that's the most important part of this PR.

* master: (79 commits) feat(perf-issues): Add performance issue detection timing runner command (#44912) Revert "chore: Investigating org slug already set to a different value (#45134)" fix(hybrid-cloud): Redirect to org restoration page for customer domains (#45159) bug(replays): Fix 500 error when marshaling tags field (#45097) ref(sourcemaps): Redesign lookup of source and sourcemaps (#45032) chore: Investigating org slug already set to a different value (#45134) feat(dynamic-sampling): Implement prioritize by project bias [TET-574] (#42939) feat(dynamic-sampling): Add transaction name prioritize option - (#45034) feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] (#44944) feat(admin) Add admin relay project config view [TET-509] (#45120) Revert "chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)" feat(sourcemaps): Implement new tables supporting debug ids (#44572) ref(js): Remove usage of react-document-title (#45170) chore(py): Consistently name urls using `organization-` prefix (#45180) ref: rename acceptance required checks collector (#45156) chore(assignment): Add analytics when autoassigning after a manual assignment (#45099) feat(source-maps): Update copy for source map debug alerts (#45164) ref(js): Remove custom usage of DocumentTitle (#45165) chore(login): update the login banners (#45151) ref(py): Remove one more legacy project_id from Environment (#45160) ...

…5139) It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context The only code that sets these three pieces of information is within the sdk.py module (see #45134 for details). This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. It is unclear if the root cause comes from a bug in the SDK or the way we tag things in our code base. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. A sample event can be seen [here](https://sentry.sentry.io/discover/sentry:99c8b9c9d2c241cc90e52c307faa45eb/?field=organization.slug&field=user.display&field=timestamp&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=issue%3ASENTRY-W7T&sort=-timestamp&statsPeriod=90d&yAxis=count%28%29) (private link) Here's a [query](https://sentry.sentry.io/discover/results/?field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&statsPeriod=14d&yAxis=count%28%29) showing some transactions that should not have org values set. There may be more transaction since I'm narrowing the query down to just `error.value:"Integration matching query does not exist."` Improves [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464)

armenzg added 3 commits February 24, 2023 14:19

WIP

3e7f3fd

Reduce changes

444417a

Report error

4c65157

armenzg requested a review from a team as a code owner February 27, 2023 18:07

armenzg requested review from a team and wedamija February 27, 2023 18:07

armenzg self-assigned this Feb 27, 2023

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2023

armenzg commented Feb 27, 2023

View reviewed changes

armenzg mentioned this pull request Feb 27, 2023

fix(github_webhooks): Reset org tags and context before available #45139

Merged

armenzg added 2 commits February 27, 2023 15:21

Set tag and use error instead of exception

f215b69

Do not import Scope

2baf267

vercel bot deployed to Preview February 27, 2023 20:27 View deployment

armenzg requested a review from sl0thentr0py February 27, 2023 21:02

armenzg commented Feb 27, 2023

View reviewed changes

sl0thentr0py approved these changes Feb 27, 2023

View reviewed changes

Merge branch 'master' into armenzg/detect-unmatching-tags

1443006

vercel bot deployed to Preview February 28, 2023 13:40 View deployment

Too many arguments

3654afe

armenzg enabled auto-merge (squash) February 28, 2023 13:50

armenzg disabled auto-merge February 28, 2023 13:51

armenzg enabled auto-merge (squash) February 28, 2023 13:51

vercel bot deployed to Preview February 28, 2023 13:52 View deployment

armenzg merged commit 76a4d84 into master Feb 28, 2023

armenzg deleted the armenzg/detect-unmatching-tags branch February 28, 2023 14:09

armenzg added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 28, 2023

getsentry-bot added a commit that referenced this pull request Feb 28, 2023

Revert "chore: Investigating org slug already set to a different value (

fb648cc

#45134)" This reverts commit 76a4d84. Co-authored-by: armenzg <44410+armenzg@users.noreply.github.com>

github-actions bot locked and limited conversation to collaborators Mar 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Investigating org slug already set to a different value#45134

chore: Investigating org slug already set to a different value#45134
armenzg merged 7 commits intomasterfrom
armenzg/detect-unmatching-tags

armenzg commented Feb 27, 2023 •

edited by atlassian bot

Loading

Uh oh!

armenzg Feb 27, 2023

Uh oh!

armenzg Feb 27, 2023 •

edited

Loading

Uh oh!

armenzg Feb 27, 2023

Uh oh!

armenzg commented Feb 27, 2023

Uh oh!

getsentry-bot commented Feb 28, 2023

Uh oh!

armenzg commented Feb 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

armenzg commented Feb 27, 2023 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

armenzg Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

armenzg Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

armenzg Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

armenzg commented Feb 27, 2023

Uh oh!

getsentry-bot commented Feb 28, 2023

Uh oh!

armenzg commented Feb 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

armenzg commented Feb 27, 2023 •

edited by atlassian bot

Loading

armenzg Feb 27, 2023 •

edited

Loading