chore(assignment): Add analytics when autoassigning after a manual assignment#45099
Merged
chore(assignment): Add analytics when autoassigning after a manual assignment#45099
Conversation
ceorourke
commented
Feb 24, 2023
| } | ||
| ) | ||
|
|
||
| activity = Activity.objects.filter( |
Member
Author
There was a problem hiding this comment.
Idk much about the autoassignment feature, this was tricky to figure out so I hope it's right 😬 if it's not please point me towards how I can determine if an issue already has a manual assignment.
ceorourke
commented
Feb 27, 2023
| project_id=project_id, | ||
| group_id=event.group.id, | ||
| ) | ||
|
|
Member
Author
There was a problem hiding this comment.
Thinking about just returning early here now - initially I thought we'd gather metrics first and then stop auto-assigning when it's already been manually assigned, but we can still gather metrics for when we would have done it.
Contributor
There was a problem hiding this comment.
I'd be ok with this too
Member
Author
There was a problem hiding this comment.
I think I'll just merge this for now and go back tomorrow to return early and write a test 😎
NisanthanNanthakumar
approved these changes
Feb 28, 2023
Contributor
NisanthanNanthakumar
left a comment
There was a problem hiding this comment.
looks good!
Contributor
|
PR reverted: e25998f |
jan-auer
added a commit
that referenced
this pull request
Feb 28, 2023
* master: (79 commits) feat(perf-issues): Add performance issue detection timing runner command (#44912) Revert "chore: Investigating org slug already set to a different value (#45134)" fix(hybrid-cloud): Redirect to org restoration page for customer domains (#45159) bug(replays): Fix 500 error when marshaling tags field (#45097) ref(sourcemaps): Redesign lookup of source and sourcemaps (#45032) chore: Investigating org slug already set to a different value (#45134) feat(dynamic-sampling): Implement prioritize by project bias [TET-574] (#42939) feat(dynamic-sampling): Add transaction name prioritize option - (#45034) feat(dyn-sampling): add new bias toggle to project details for prioritise by tx name [TET-717] (#44944) feat(admin) Add admin relay project config view [TET-509] (#45120) Revert "chore(assignment): Add analytics when autoassigning after a manual assignment (#45099)" feat(sourcemaps): Implement new tables supporting debug ids (#44572) ref(js): Remove usage of react-document-title (#45170) chore(py): Consistently name urls using `organization-` prefix (#45180) ref: rename acceptance required checks collector (#45156) chore(assignment): Add analytics when autoassigning after a manual assignment (#45099) feat(source-maps): Update copy for source map debug alerts (#45164) ref(js): Remove custom usage of DocumentTitle (#45165) chore(login): update the login banners (#45151) ref(py): Remove one more legacy project_id from Environment (#45160) ...
ceorourke
added a commit
that referenced
this pull request
Mar 1, 2023
This is a followup to #45099 (which was reverted) that fully implements skipping automatic assignment if the issue has already been manually assigned by a user. See [WOR-2320](https://getsentry.atlassian.net/browse/WOR-2320) for full context. [WOR-2320]: https://getsentry.atlassian.net/browse/WOR-2320?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an analytics event when a user has already manually assigned an issue and we then auto-assign it.
See WOR-2320 for more in depth explanation.