feat(CapMan): Pass tenant_ids to Snuba#44788
Merged
rahul-kumar-saini merged 10 commits intomasterfrom Feb 28, 2023
Merged
Conversation
evanh
reviewed
Feb 28, 2023
JoshFerge
approved these changes
Feb 28, 2023
Member
JoshFerge
left a comment
There was a problem hiding this comment.
seems safe. couple questions on consistency:
- why are some referrers defined in a constants file and others not?
- why do some referrers use underscores and others dashes?
Contributor
Author
I only refactored existing referrers within the same function and added 1 new one following the same convention as another referrer in the same file. I'm not sure what the guidance around referrers is but it seems most implementations have their own version, this inconsistency existed before I made any changes. |
jan-auer
added a commit
that referenced
this pull request
Mar 1, 2023
* master: (37 commits) ref(ppf): Don't use --commit-batch-size for futures queue length (#45182) feat(codecov-v2): Add more logging (#45225) fix(alerts): Center table items on alert history page (#45226) feat(CapMan): Pass `tenant_ids` to Snuba (#44788) ref(db): Drop `project_id` from Environment (model state) (#45207) chore(profiling): Rename context in profiles task (#45208) feat(replays): Improve index page query performance (#45098) chore(issue assignment): Add logging for`GroupOwner` auto assignment (#45142) fix(hybrid-cloud): Uncache organization when queueing it for deletion (#45213) fix(perf): Navigating to Transaction Summary from Trends widget should persist custom date selection (#45190) fix(pageFilter): Fix overflow (#45169) ref(git hooks): Only suggest autoupdate variable when pulling if not already set (#45179) fix(dashboard): Include dashboard filters in widget viewer (#45106) fix(alerts): Remove null projects from alerts list (#45202) feat(replay): Update Inline replay onboarding img to support dark mode (#45084) __iexact reduce call has default value now. (#45206) feat(replay): Use SDK value for LCP (#44868) chore(hybrid-cloud): breaking foreign keys (#45203) Revert "ref(db): Drop `project_id` from Environment (model state) (#45094)" ref(db): Drop `project_id` from Environment (model state) (#45094) ...
rahul-kumar-saini
added a commit
that referenced
this pull request
Mar 2, 2023
### Overview - Added `organization_id` to more Snuba Requests, specifically targeting `tsdb-modelid:4` queries as they are the biggest chunk of queries Snuba is handling in production - Most calls to `tsdb.get_range` handled as well, some I wasn't able to figure out - More context: #44788
This was referenced Mar 3, 2023
rahul-kumar-saini
added a commit
that referenced
this pull request
Mar 7, 2023
### Overview - Added `organization_id` to more Snuba Requests, specifically targeting `tsdb-modelid:300` and `tsdb-modelid:100` - Legacy queries now pass `tenant_ids` to Snuba as well - Removed hardcoded referrer in tenant_ids, moved to populate referrer in query functions - More context: #44788
rahul-kumar-saini
added a commit
that referenced
this pull request
Mar 8, 2023
- All Tagstore Snuba queries now pass the `organization_id` tenant_id in the request - See #44788 for more context
rahul-kumar-saini
added a commit
that referenced
this pull request
Mar 14, 2023
### Overview - All Snuba queries built and executed with `QueryBuilder` objects now contain org ID in `tenant_ids` for their Snuba Requests - Outcomes Timeseries Queries now have tenant_ids - Search queries now have tenant_ids - See #44788 for more context
rahul-kumar-saini
added a commit
that referenced
this pull request
Mar 15, 2023
### Overview - All Eventstore queries now contain `tenant_ids` - See #44788 for more context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changes
organization_idandreferrer(referrer already existed but this PR adds it to the dictionary)tenant_idsper requestorganization_idfrom some easy use cases of the Snuba API and will be working on more complicated ones in future PRsNotes