feat(CapMan): Tagstore Org IDs passed to Snuba#45454
feat(CapMan): Tagstore Org IDs passed to Snuba#45454rahul-kumar-saini merged 24 commits intomasterfrom
Conversation
wedamija
left a comment
There was a problem hiding this comment.
lgtm, although looks like you need to add tenant ids to sentry.snuba.metrics.get_tag_values
|
|
||
| project_id = issue_list[0].project_id | ||
| item_ids = [g.id for g in issue_list] | ||
| tenant_ids = {"organization_id": issue_list[0].project.organization_id} |
There was a problem hiding this comment.
Just noting that we preload group projects here
, so this won't cause an extra query.There was a problem hiding this comment.
I'm new to Django, are you saying I'm causing an extra query by doing .project.organization_id? How can I avoid this if so?
There was a problem hiding this comment.
No, just noting for anyone else reading that it won't cause any extra load
Lmk if I'm missing any other query somewhere in this stack 😅 |
This is what's causing the test failure though - something is attempting to pass tenant_ids to |
organization_idtenant_id in the requesttenant_idsto Snuba #44788 for more context