chore(ts): Initial typescript conversion in preparation of discover v2#14345
Merged
chore(ts): Initial typescript conversion in preparation of discover v2#14345
Conversation
b4c61eb to
f3ca36a
Compare
c145f15 to
4507aeb
Compare
4507aeb to
cb5dc2f
Compare
27b6d10 to
76e1712
Compare
76e1712 to
6f903f1
Compare
11f9290 to
f0610ff
Compare
616b21f to
a9393d5
Compare
81c00c5 to
5aef1b9
Compare
markstory
reviewed
Aug 22, 2019
Member
There was a problem hiding this comment.
Longer term, I want to fold down data as this extra layer isn't providing any value.
src/sentry/static/sentry/app/views/organizationEventsV2/modalPagination.tsx
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Should this have per_page as well?
markstory
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precursor to SEN-806
TODO
extends feat(discover2) Add more aggregate field support #14321 and feat(events2) Add metadata to responses and generalize column formatting #14340
relies on chore(ts): Convert src/sentry/static/sentry/app/utils.jsx to typescript #14199
cherry pick chore(ts): api.jsx to api.tsx #14148
chore(ts): Better generics for getDynamicText function #14415
chore(ts): Mark proptypes of AsyncComponent to be any #14412
chore(ts): Conversion of constant-based files to TS #14411
feat(ts): Add Client type to withAPI #14475
updateEDIT: split to React router location dump #14476history@3types upstream history@3.x: Provide default type for Query type; since history@3.x provides a default query-string parser DefinitelyTyped/DefinitelyTyped#37657 (optional)