Conversation
58d3443 to
d130c69
Compare
f7ed133 to
a276ec7
Compare
a276ec7 to
4581ac8
Compare
markstory
reviewed
Aug 15, 2019
src/sentry/static/sentry/app/views/organizationEventsV2/table.tsx
Outdated
Show resolved
Hide resolved
markstory
reviewed
Aug 16, 2019
src/sentry/static/sentry/app/views/organizationEventsV2/index.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationEventsV2/relatedEvents.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/organizationEventsV2/table.tsx
Outdated
Show resolved
Hide resolved
8c3bb26 to
727d7e1
Compare
dashed
commented
Aug 28, 2019
|
|
||
| with self.feature(FEATURE_NAME): | ||
|
|
||
| error_view = 'field=%5B"title"%2C"error"%5D&field=%5B"count%28id%29"%2C"events"%5D&field=%5B"count_unique%28user%29"%2C"users"%5D&field=%5B"project"%2C"project"%5D&field=%5B"last_seen"%2C"last+seen"%5D&name=Errors&query=event.type%3Aerror&sort=-last_seen&sort=-title&tag=error.type&tag=project.name' |
Member
Author
There was a problem hiding this comment.
@markstory I hardcoded this for now. We may need a utility function to encode some dict into query strings.
Member
Author
|
@leedongwei @markstory I've addressed the acceptance/js tests for this PR, and either of you can take over. Mark has some remaining feedback that are yet to be addressed (please see unresolved comments in the PR). |
dashed
commented
Aug 28, 2019
| getCurrentSort(): string { | ||
| const {defaultSort, location} = this.props; | ||
| return location.query.sort ? location.query.sort : defaultSort; | ||
| return typeof location.query.sort === 'string' ? location.query.sort : defaultSort; |
Member
Author
There was a problem hiding this comment.
location.query.sort can also be Array<string>; if it is and non-empty, we can use the first item.
dashed
commented
Aug 28, 2019
|
|
||
| if (typeof name === 'string' && String(name).trim().length > 0) { | ||
| return [t('Events'), String(name).trim()]; | ||
| // return `${} \u2014 ${}`; |
markstory
approved these changes
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
Extends #14345
TODO
revamped data view schemaEDIT:EventViewclass abstractionUnresolved
are there illegal characters for field name/aggr(name)?EDIT: addressed with JSON stringifyare there illegal characters for col name?EDIT: addressed with JSON stringifyDeferred
Closes SEN-806
Closes SEN-907