Skip to content

history@3.x: Provide default type for Query type; since history@3.x provides a default query-string parser#37657

Merged
sheetalkamat merged 3 commits intoDefinitelyTyped:masterfrom
dashed:update-type-history@3
Aug 22, 2019
Merged

history@3.x: Provide default type for Query type; since history@3.x provides a default query-string parser#37657
sheetalkamat merged 3 commits intoDefinitelyTyped:masterfrom
dashed:update-type-history@3

Conversation

@dashed
Copy link
Contributor

@dashed dashed commented Aug 15, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:


For context, I'm helping migrate sentry to typescript (https://github.com/getsentry/sentry), and I'm updating the types upstream on history@3, which will hopefully propagate to react-router@3.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Aug 15, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 15, 2019

@dashed Thank you for submitting this PR!

🔔 @sergey-buturlakin @ngbrown @rokoroku @LKay @huy-nguyen @8398a7 @mykolas @isman-usoh @noah79 @rosendi @DovydasNavickas - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 15, 2019

@dashed The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@dashed dashed force-pushed the update-type-history@3 branch from 29b3c1b to 239dae5 Compare August 16, 2019 23:31
@typescript-bot typescript-bot added Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. and removed The Travis CI build failed labels Aug 17, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@sheetalkamat sheetalkamat merged commit 97d8f40 into DefinitelyTyped:master Aug 22, 2019
@typescript-bot
Copy link
Contributor

I just published @types/history@3.2.4 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts). Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants