history@3.x: Provide default type for Query type; since history@3.x provides a default query-string parser#37657
Conversation
|
@dashed Thank you for submitting this PR! 🔔 @sergey-buturlakin @ngbrown @rokoroku @LKay @huy-nguyen @8398a7 @mykolas @isman-usoh @noah79 @rosendi @DovydasNavickas - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@dashed The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
…rovides a default query-string parser
29b3c1b to
239dae5
Compare
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
|
I just published |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
Provide a URL to documentation or source code which provides context for the suggested changes:
history@3usesquery-string@4.2.2to provide the default querey string parsing. see:https://github.com/ReactTraining/history/blob/314ce46f31f91e45a68e2f6d29cb974afc606842/modules/useQueries.js#L24
https://github.com/ReactTraining/history/blob/v3/docs/QuerySupport.md
https://github.com/ReactTraining/history/blob/314ce46f31f91e45a68e2f6d29cb974afc606842/package.json#L26
In terms of the types I'm using: https://github.com/sindresorhus/query-string/blob/master/index.d.ts#L92-L94
The API in
query-string@4.2.2matches the types: https://github.com/sindresorhus/query-string/tree/v4.2.2#apiFor context, I'm helping migrate sentry to typescript (https://github.com/getsentry/sentry), and I'm updating the types upstream on
history@3, which will hopefully propagate toreact-router@3.