ref(events-v2) Remove group prop from many interface components#13422
Merged
ref(events-v2) Remove group prop from many interface components#13422
Conversation
Many of the event interface ui components had `group` as a required prop but it isn't used other than to pass onto EventDataSection which also doesn't use the prop. By removing all these redundant props I can fix numerous prop type warnings that are blocking the modal for events-v2. Refs SEN-697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the event interface ui components had
groupas a required prop but it isn't used other than to pass onto EventDataSection which also doesn't use the prop. By removing all these redundant props I can fix numerous prop type warnings that are blocking the modal for events-v2.Refs SEN-697
Related to #13415