Skip to content

fix(rrweb): null check for pointer#208

Merged
michellewzhang merged 1 commit intosentry-v2from
mz/null-pointer-check
Jun 18, 2024
Merged

fix(rrweb): null check for pointer#208
michellewzhang merged 1 commit intosentry-v2from
mz/null-pointer-check

Conversation

@michellewzhang
Copy link

@michellewzhang michellewzhang requested a review from a team June 18, 2024 20:05
@@ -2179,7 +2179,7 @@ export class Replayer {
private drawMouseTail(position: { x: number; y: number }, pointerId: number) {
const pointer = this.pointers[pointerId];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the trick to tell typescript that pointer could be null, then we'll get all the typehints:

Suggested change
const pointer = this.pointers[pointerId];
const pointer = this.pointers.at(pointerId);

Copy link
Author

@michellewzhang michellewzhang Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that gives me a lint error :(

Unsafe assignment of an `any` value. 

eslint@typescript-eslint/no-unsafe-assignment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, think pointers is a Record type, i assumed array without looking.

nbd.

@michellewzhang michellewzhang merged commit 011bd05 into sentry-v2 Jun 18, 2024
@michellewzhang michellewzhang deleted the mz/null-pointer-check branch June 18, 2024 20:18
chargome added a commit that referenced this pull request Mar 25, 2026
Remove lerna and replace its two uses with lighter alternatives:

- **`lerna version`** → `scripts/bump-version.js` — a ~80-line Node
script that updates all workspace `package.json` versions and
`@sentry-internal/*` cross-references to the exact new version. Modeled
after
[sentry-javascript#19325](getsentry/sentry-javascript#19325).
- **`lerna run build:tarball`** → `turbo run build:tarball` — Turborepo
is already used for all other cross-package tasks.

Lerna was pulling in a large transitive dependency tree including
packages with known vulnerabilities. This removes ~2,300 lines from
`yarn.lock`.

### Dependabot alerts resolved

**Fully resolved** (vulnerable package completely removed from
lockfile):

| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #217 | HIGH | `tar` | Symlink Path Traversal via Drive-Relative
Linkpath |
| #216 | HIGH | `tar` | Hardlink Path Traversal via Drive-Relative
Linkpath |
| #185 | HIGH | `tar` | Arbitrary File Read/Write via Hardlink Target
Escape Through Symlink Chain |
| #176 | HIGH | `tar` | Arbitrary File Creation/Overwrite via Hardlink
Path Traversal |
| #174 | HIGH | `tar` | Race Condition via Unicode Ligature Collisions
on macOS APFS |
| #172 | HIGH | `tar` | Arbitrary File Overwrite and Symlink Poisoning
via Insufficient Path Sanitization |
| #137 | HIGH | `axios` | SSRF and Credential Leakage via Absolute URL |

**Partially resolved** (some vulnerable entries removed, but the package
still exists via other dependency chains):

| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #213, #208, #207, #205 | HIGH | `minimatch` | `markdownlint-cli`,
`vite-plugin-dts` still pull in vulnerable versions |
| #161 | HIGH | `glob` | `markdownlint-cli`, `web-ext-run` still pull in
vulnerable versions |
| #136, #135 | CRITICAL | `form-data` | `jest` (via jsdom) still pulls
in `form-data@3.0.2` |
| #158, #157 | MEDIUM | `js-yaml` | `@changesets/cli`, `jest` still pull
in `js-yaml@3.14.1` |

The partially resolved alerts will be addressed in later phases (Phase
6: mop up remaining — bumping `markdownlint-cli`, `@changesets/cli`,
`jest`/rrvideo, etc.).

Part of the ongoing effort to resolve all Dependabot alerts on this
repo.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants