Skip to content

feat: Register errorHandler inside of CanvasManager#161

Merged
billyvg merged 3 commits intosentry-v2from
feat-pass-error-handler-to-canvas-manager
Jan 31, 2024
Merged

feat: Register errorHandler inside of CanvasManager#161
billyvg merged 3 commits intosentry-v2from
feat-pass-error-handler-to-canvas-manager

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Jan 29, 2024

Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught exceptions from createImageBitmap

@github-actions
Copy link

github-actions bot commented Jan 29, 2024

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.69 KB (0%)
rrweb - record & CanvasManager only (gzipped) 19.35 KB (+0.05% 🔺)
rrweb - record only (min) 56.96 KB (+0.03% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.47 KB (+0.02% 🔺)

@billyvg billyvg marked this pull request as ready for review January 29, 2024 22:57
@billyvg billyvg requested review from c298lee and mydea January 29, 2024 22:57
… attributes (#160)

Probably fixes
getsentry/sentry-javascript#10292

Not sure how `attr.name` could be undefined here but according to the
issue, it happens and we should probably guard adding the attribute.
@billyvg billyvg force-pushed the feat-pass-error-handler-to-canvas-manager branch from 4e88f4e to 07e4a5e Compare January 30, 2024 00:13
Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught exceptions from `createImageBitmap`
@billyvg billyvg force-pushed the feat-pass-error-handler-to-canvas-manager branch from 07e4a5e to a67d9b9 Compare January 30, 2024 00:14
@billyvg billyvg merged commit c79619f into sentry-v2 Jan 31, 2024
@billyvg billyvg deleted the feat-pass-error-handler-to-canvas-manager branch January 31, 2024 16:05
billyvg added a commit that referenced this pull request Apr 26, 2024
Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught
exceptions from `createImageBitmap`

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
chargome added a commit that referenced this pull request Mar 25, 2026
Remove lerna and replace its two uses with lighter alternatives:

- **`lerna version`** → `scripts/bump-version.js` — a ~80-line Node
script that updates all workspace `package.json` versions and
`@sentry-internal/*` cross-references to the exact new version. Modeled
after
[sentry-javascript#19325](getsentry/sentry-javascript#19325).
- **`lerna run build:tarball`** → `turbo run build:tarball` — Turborepo
is already used for all other cross-package tasks.

Lerna was pulling in a large transitive dependency tree including
packages with known vulnerabilities. This removes ~2,300 lines from
`yarn.lock`.

### Dependabot alerts resolved

**Fully resolved** (vulnerable package completely removed from
lockfile):

| Alert | Severity | Package | Summary |
|-------|----------|---------|---------|
| #217 | HIGH | `tar` | Symlink Path Traversal via Drive-Relative
Linkpath |
| #216 | HIGH | `tar` | Hardlink Path Traversal via Drive-Relative
Linkpath |
| #185 | HIGH | `tar` | Arbitrary File Read/Write via Hardlink Target
Escape Through Symlink Chain |
| #176 | HIGH | `tar` | Arbitrary File Creation/Overwrite via Hardlink
Path Traversal |
| #174 | HIGH | `tar` | Race Condition via Unicode Ligature Collisions
on macOS APFS |
| #172 | HIGH | `tar` | Arbitrary File Overwrite and Symlink Poisoning
via Insufficient Path Sanitization |
| #137 | HIGH | `axios` | SSRF and Credential Leakage via Absolute URL |

**Partially resolved** (some vulnerable entries removed, but the package
still exists via other dependency chains):

| Alert | Severity | Package | Remaining source |
|-------|----------|---------|-----------------|
| #213, #208, #207, #205 | HIGH | `minimatch` | `markdownlint-cli`,
`vite-plugin-dts` still pull in vulnerable versions |
| #161 | HIGH | `glob` | `markdownlint-cli`, `web-ext-run` still pull in
vulnerable versions |
| #136, #135 | CRITICAL | `form-data` | `jest` (via jsdom) still pulls
in `form-data@3.0.2` |
| #158, #157 | MEDIUM | `js-yaml` | `@changesets/cli`, `jest` still pull
in `js-yaml@3.14.1` |

The partially resolved alerts will be addressed in later phases (Phase
6: mop up remaining — bumping `markdownlint-cli`, `@changesets/cli`,
`jest`/rrvideo, etc.).

Part of the ongoing effort to resolve all Dependabot alerts on this
repo.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants