ref(normalization): Remove duplicated normalization#3355
Merged
iker-barriocanal merged 2 commits intomasterfrom Mar 28, 2024
Merged
ref(normalization): Remove duplicated normalization#3355iker-barriocanal merged 2 commits intomasterfrom
iker-barriocanal merged 2 commits intomasterfrom
Conversation
| } | ||
|
|
||
| /// Defaults the `platform` and `level` required attributes. | ||
| fn normalize_platform_and_level(event: &mut Event) { |
Contributor
Author
There was a problem hiding this comment.
These are normalized in
relay/relay-event-normalization/src/event.rs
Lines 1030 to 1033 in 9bf4cbe
Comment on lines
+1525
to
+1528
| "type": "error", | ||
| "exception": { | ||
| "values": [{"type": "ValueError", "value": "Should not happen"}] | ||
| } |
Contributor
Author
There was a problem hiding this comment.
type is not enough for an event to be considered an error, see
relay/relay-event-normalization/src/event.rs
Line 1057 in 9bf4cbe
Dav1dde
reviewed
Mar 28, 2024
Dav1dde
approved these changes
Mar 28, 2024
jan-auer
added a commit
that referenced
this pull request
Apr 3, 2024
* master: feat(metric-stats): Report cardinality to metric stats (#3360) release: 0.8.56 fix(perfscore): Adds span op tag to perf score totals (#3326) ref(profiles): Return retention_days as part of the Kafka message (#3362) ref(filter): Add GTmetrix to the list of web crawlers (#3363) fix: Fix kafka topic default (#3350) ref(normalization): Remove duplicated normalization (#3355) feat(feedback): Emit outcomes for user feedback events (#3026) feat(cardinality): Implement cardinality reporting (#3342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When light normalization was introduced, the normalization of
platformandlevelwas duplicated from the store normalization. Now that there's a single normalization step, this PR removes that duplication.#skip-changelog