fix(perfscore): Adds span op tag to perf score totals#3326
Merged
edwardgou-sentry merged 3 commits intomasterfrom Apr 2, 2024
Merged
fix(perfscore): Adds span op tag to perf score totals#3326edwardgou-sentry merged 3 commits intomasterfrom
edwardgou-sentry merged 3 commits intomasterfrom
Conversation
jjbayer
approved these changes
Mar 26, 2024
Member
jjbayer
left a comment
There was a problem hiding this comment.
@edwardgou-sentry could you please add test coverage for this change? For example by expanding the following test a bit. Currently it only looks at metric names, it could assert on tags as well:
relay/relay-server/src/metrics_extraction/event.rs
Lines 1418 to 1419 in 79472d3
jan-auer
added a commit
that referenced
this pull request
Apr 3, 2024
* master: feat(metric-stats): Report cardinality to metric stats (#3360) release: 0.8.56 fix(perfscore): Adds span op tag to perf score totals (#3326) ref(profiles): Return retention_days as part of the Kafka message (#3362) ref(filter): Add GTmetrix to the list of web crawlers (#3363) fix: Fix kafka topic default (#3350) ref(normalization): Remove duplicated normalization (#3355) feat(feedback): Emit outcomes for user feedback events (#3026) feat(cardinality): Implement cardinality reporting (#3342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates score total measurements to be tagged by
span.op. We need to be able to filter scores based onspan.opas we may have more standalone spans in the future with different score profiles (such as mobile).#skip-changelog