fix(spans): Scrub integer file extensions#2856
Conversation
Dav1dde
left a comment
There was a problem hiding this comment.
Maybe we should just have a whitelist of extensions instead?
@Dav1dde That's a good point. @DominikB2014 would the list of supported images be short enough to enumerate? |
We do have a list of extensions that we look for in the FE This mostly lines up with https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types But I'm not sure if this includes all types tho. Are we able to query for all extensions that we have seen to be sure? |
* master: (35 commits) fix(spans): Parse quotes in MySQL (#2846) ref(cardinality): Use a Lua script and in-memory cache for the cardinality limiter (#2849) fix(spans): Detect hex with fallback scrubber (#2868) release: 23.12.0 Revert "ci: Update upload-artifact and download-artifact actions" (#2866) Revert "build: Update axum and http" (#2863) feat(spans): Allow resource.img spans (#2855) build: Update axum and http (#2844) fix(build): Add additional dependencies to the release build (#2858) ci: Update upload-artifact and download-artifact actions (#2861) feat(spans): Parse timestamps from strings (#2857) fix(spans): Scrub integer file extensions (#2856) feat(spans): Remove unused transaction tag from resource metrics (#2853) ref(cardinality): Recover buckets on cardinality limiter failure (#2852) feat(server): Org rate limit per metric bucket (#2836) ref(spans): List metric tags explicitly (#2834) feat(spans): Resource response sizes as measurements (#2845) feat(crons): Add thresholds to monitor config payload (#2842) feat(spans): Allow ingestion of metrics summary on spans (#2823) ref(crons): Add documentation to CheckInMessageType (#2840) ...
@DominikB2014 I ran a query and posted the results here, let me know which of those you would like to add to the allowlist! |
We've seen resource span descriptions like
http://domain.com/*.123which cause high cardinality in the extension.#skip-changelog