feat(crons): Add thresholds to monitor config payload#2842
Merged
Conversation
Comment on lines
+111
to
+115
| failure_issue_threshold: Option<u64>, | ||
|
|
||
| /// How many consecutive OK check-ins it takes to resolve an issue | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| recovery_threshold: Option<u64>, |
Member
There was a problem hiding this comment.
Let's make sure to add these to the develop.sentry.dev SDK docs as well.
evanpurkhiser
approved these changes
Dec 12, 2023
olksdr
reviewed
Dec 12, 2023
Contributor
olksdr
left a comment
There was a problem hiding this comment.
It would be great to keep the naming consistent throughout the docs, checkin vs. check-in
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
jan-auer
added a commit
that referenced
this pull request
Dec 19, 2023
* master: (35 commits) fix(spans): Parse quotes in MySQL (#2846) ref(cardinality): Use a Lua script and in-memory cache for the cardinality limiter (#2849) fix(spans): Detect hex with fallback scrubber (#2868) release: 23.12.0 Revert "ci: Update upload-artifact and download-artifact actions" (#2866) Revert "build: Update axum and http" (#2863) feat(spans): Allow resource.img spans (#2855) build: Update axum and http (#2844) fix(build): Add additional dependencies to the release build (#2858) ci: Update upload-artifact and download-artifact actions (#2861) feat(spans): Parse timestamps from strings (#2857) fix(spans): Scrub integer file extensions (#2856) feat(spans): Remove unused transaction tag from resource metrics (#2853) ref(cardinality): Recover buckets on cardinality limiter failure (#2852) feat(server): Org rate limit per metric bucket (#2836) ref(spans): List metric tags explicitly (#2834) feat(spans): Resource response sizes as measurements (#2845) feat(crons): Add thresholds to monitor config payload (#2842) feat(spans): Allow ingestion of metrics summary on spans (#2823) ref(crons): Add documentation to CheckInMessageType (#2840) ...
This was referenced Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
failure_issue_thresholdandrecovery_thresholdintoMonitorConfigpayload. Allows for SDKs to set thresholds programmatically via upsert.