ref(statsd): Revert back the adition of metric names as tag on Sentry errors#1873
Merged
iker-barriocanal merged 3 commits intomasterfrom Feb 23, 2023
Merged
ref(statsd): Revert back the adition of metric names as tag on Sentry errors#1873iker-barriocanal merged 3 commits intomasterfrom
iker-barriocanal merged 3 commits intomasterfrom
Conversation
This reverts commit d873ce2.
olksdr
approved these changes
Feb 22, 2023
jan-auer
added a commit
that referenced
this pull request
Feb 23, 2023
* master: feat(metrics): Tag the sample decision on count_per_root_project (#1870) feat(protocol): Add sourcemap debug image type to protocol (#1869) ref(statsd): Revert back the adition of metric names as tag on Sentry errors (#1873) feat(profiling): Add PHP support (#1871) fix(panic): revert sentry-types to 0.20.1 (#1872) ref(server): Use async/await in all endpoints (#1862) ref: Buffer envelopes for broken project states (#1856) meta: Remove accidentally added GeoIP file (#1866)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1797 added metric names as tags on Sentry errors, as part of an experiment to provide more visibility on what metrics was relay dropping for the channel being full (sentry issue). In the last 3 weeks (since this "experiment" started), there have been no errors; thus, I'm reverting the experiment and not getting any conclusions.
If relay starts dropping metrics again, we'll revisit this problem.