feat(protocol): Add sourcemap debug image type to protocol#1869
Merged
feat(protocol): Add sourcemap debug image type to protocol#1869
Conversation
jjbayer
approved these changes
Feb 22, 2023
jan-auer
approved these changes
Feb 23, 2023
jan-auer
added a commit
that referenced
this pull request
Feb 23, 2023
* master: feat(metrics): Tag the sample decision on count_per_root_project (#1870) feat(protocol): Add sourcemap debug image type to protocol (#1869) ref(statsd): Revert back the adition of metric names as tag on Sentry errors (#1873) feat(profiling): Add PHP support (#1871) fix(panic): revert sentry-types to 0.20.1 (#1872) ref(server): Use async/await in all endpoints (#1862) ref: Buffer envelopes for broken project states (#1856) meta: Remove accidentally added GeoIP file (#1866)
Contributor
|
When will this be deployed? |
Member
@lforst : https://freight.getsentry.net/deploys/relay-pop/production/307 |
Contributor
Awesome! Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the new
sourcemapimage type to the protocol so that it's possible to associate entries in the stack trace with debug files. Likeabs_pathwe are exempting this from PII stripping so that they are not destroyed in the process for mapping purposes.{ "code_file": "https://mycdn.invalid/foo.js.min", "debug_id": "971f98e5-ce60-41ff-b2d7-235bbeb34578", "debug_file": "https://mycdn.invalid/foo.js.map", "other": "value", "type": "sourcemap" }Refs getsentry/sentry#44885
Resolves #1846