This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Discourage use of transaction source unknown#667
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sthagen
pushed a commit
to sthagen/getsentry-sentry-python
that referenced
this pull request
Aug 14, 2022
Fixes getsentry#1557 see getsentry/develop#667 `unknown` is only supposed to be inferred by relay as a default and not set by any SDKs. Additionally, fix some of the other cases where start_transaction was begin called without a source in integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unknownshould only be set by Relay, as a value for SDKs that do not send thesourceattribute.