fix(changelog): Use PR-specific bump type in preview #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Changelog
OtherBug Fixes 🐛Documentation 📚🤖 This preview updates automatically when you update the PR. |
Contributor
|
When generating changelog preview for a PR, the bump type was incorrectly calculated from ALL commits since the last tag instead of just the current PR. This caused PRs with patch-level changes (e.g., chore:, ref:) to show 'minor' if any feature commits existed in the changelog history. Now we use getBumpTypeForPR() to calculate the bump type for the specific PR being previewed, consistent with the behavior when the PR is skipped. Also updates the workflow wording from 'Suggested Version Bump' to 'Semver Impact of This PR' to clarify the meaning.
dd9a01a to
96ee673
Compare
…ghlight The function was returning hardcoded statistics (totalCommits: 1, matchedCommitsWithSemver: 0 or 1) while the changelog itself was generated from all commits. This caused misleading CLI output and incorrect log messages in the auto-versioning process. Now uses the stats from categorizeCommits which reflect all commits processed for the changelog, while keeping the bumpType PR-specific.
MathurAditya724
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When generating changelog preview for a PR, the "Suggested version bump" was incorrectly showing the bump type from ALL commits since the last tag instead of just the current PR.
For example, if the changelog history contained a
feat:commit (minor) but the current PR waschore:(patch), the preview would incorrectly show "minor" instead of "patch".This was observed in PRs like #675 where the bump type didn't match the PR's change type.
Solution
getBumpTypeForPR()instead of using the aggregated stats from all commitsChanges
src/utils/changelog.ts: Use PR-specific bump type ingenerateChangelogWithHighlight().github/workflows/changelog-preview.yml: Update section heading wording