chore: modernize dev toolchain #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Suggested Version Bump🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
|
- Upgrade Prettier from 2.x to 3.4.2 - Upgrade TypeScript to 5.7.2 - Migrate ESLint 7 to ESLint 9 with flat config (eslint.config.mjs) - Replace Jest with Vitest for faster, native ESM testing - Replace AJV/json-schema-to-typescript with Zod for schema validation - Update @octokit packages to latest major versions - Update @aws-sdk and @google-cloud/storage - Remove obsolete yarn resolutions - Update AGENTS.md documentation
- Add trace method to logger mock - Fix strings test to handle different stack trace formats - Fix system tests to use more portable node commands
- Use vi.useFakeTimers/useRealTimers in calver.test.ts - Properly export all fs methods in fs mock
- Replace jest.fn() with vi.fn() in multiple test files - Fix inline snapshot in symbolCollector.test.ts - Use require for actual fs import in mock to avoid circular issues
- Remove global fs mock in gcsAPI.test.ts, use vi.spyOn instead - Add AWS Lambda client mock in awsLambdaLayerManager.test.ts
- Use vi.mock factory for fs module to mock existsSync - Add default export for simple-git mock
475e7ef to
e5f1fce
Compare
MathurAditya724
approved these changes
Dec 28, 2025
BYK
added a commit
that referenced
this pull request
Dec 28, 2025
## Problem When generating changelog preview for a PR, the "Suggested version bump" was incorrectly showing the bump type from ALL commits since the last tag instead of just the current PR. For example, if the changelog history contained a `feat:` commit (minor) but the current PR was `chore:` (patch), the preview would incorrectly show "minor" instead of "patch". This was observed in PRs like #675 where the bump type didn't match the PR's change type. ## Solution - Calculate the bump type for the specific PR using `getBumpTypeForPR()` instead of using the aggregated stats from all commits - This is now consistent with the behavior when a PR is skipped (which was already correct) - Updated workflow wording from "Suggested Version Bump" to "Semver Impact of This PR" to clarify the meaning ## Changes - `src/utils/changelog.ts`: Use PR-specific bump type in `generateChangelogWithHighlight()` - `.github/workflows/changelog-preview.yml`: Update section heading wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive upgrade of the development toolchain to modern versions.
#skip-changelog
Changes
Linting & Formatting
eslint.config.mjs)Testing
vi.fn(),vi.mock(), etc.)Schema Validation
Dependencies
Breaking Changes
None for users. Internal tooling only.
Files Removed
.eslintrc.jsjest.config.jsscripts/config-json-schema-to-ts.jssrc/schemas/projectConfig.schema.tsFiles Added
eslint.config.mjsvitest.config.ts