feat: Run Craft outside of Docker and bundle publish request #4
Merged
Conversation
This PR bundles the 'Craft Prepare' and 'Request publish' steps by leveraging the fact that Craft can be run outside of the Docker image, w/o the Craft action as done in getsentry/sentry-javascript#3130. It also improves the automatically crated publish request issue's body by adding the comparison link, normally produced by Craft and tagging the initiator/requester of the release. This PR **SHOULD NOT** be merged before pinning all dependents of `action-prepare-release` as it is very likely to break them. This action now requirest `action/checkout` to be run beforehand.
chadwhitacre
approved these changes
Dec 22, 2020
chadwhitacre
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable, have not tested. Per commit message need to pin downstreams first to avoid inconsistency.
5822d31 to
d53d15b
Compare
jan-auer
requested changes
Dec 23, 2020
jan-auer
left a comment
Member
There was a problem hiding this comment.
Optional Suggestion:
Most of our repositories do not use calver, and instead a version should be required. I would add an input to toggle calver that defaults to off:
inputs:
# ...
calver:
description: Creates a CalVer release for the current date if no `version` is specified.
required: false
default: false
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/snuba
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/relay
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
This was referenced Jan 5, 2021
BYK
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/self-hosted
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/sentry-cli
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/snuba
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/self-hosted
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/sentry-cli
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/relay
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
BYK
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jan 5, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
Co-authored-by: Jan Michael Auer <mail@jauer.org>
chadwhitacre
approved these changes
Jan 5, 2021
chadwhitacre
left a comment
Contributor
There was a problem hiding this comment.
Seems reasonable. Did not test. One question about an input description.
jan-auer
approved these changes
Jan 6, 2021
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 6, 2021
Stats utilizing the latest niceties in getsentry/action-prepare-release#4.
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jan 6, 2021
…159) Stats utilizing the latest niceties in getsentry/action-prepare-release#4.
BYK
pushed a commit
to getsentry/publish
that referenced
this pull request
Jan 7, 2021
In getsentry/action-prepare-release#4, we unintentionally changed the format of the issue title. - Before: `publish: <repo>@<version>` - After: `publish: <owner>/<repo>@<version>` This is because the `GITHUB_REPOSITORY` env variable includes the full owner and repo name. There is also an `GITHUB_REPOSITORY_OWNER` variable, but none that only contains the repo name. This means we have two options: 1. In the prepare action, remove the owner from the repo. 2. In the publish action, assume there's an _optional_ owner. In this PR, I'm going with option 2, ~~although it is not backwards compatible. This means we will have to change all existing actions before attempting the next release.~~
nEdAy
pushed a commit
to nEdAy/onpremise
that referenced
this pull request
Jan 13, 2021
This is to avoid any issues when getsentry/action-prepare-release#4 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bundles the 'Craft Prepare' and 'Request publish' steps by leveraging the fact that Craft can be run outside of the Docker image, w/o the Craft action as done in getsentry/sentry-javascript#3130. It also improves the automatically crated publish request issue's body by adding the comparison link, normally produced by Craft and tagging the initiator/requester of the release.
This PR SHOULD NOT be merged before pinning all dependents ofaction-prepare-releaseas it is very likely to break them.This action now requires
action/checkoutto be run beforehand.