fix: Parse title including owner#39
Merged
Merged
Conversation
Member
Author
|
We could parse the owner as optional component, too. I would rather not do this, since we will remove all legacy actions very soon and it just increases complexity of the regex. |
Member
Author
|
Thanks, updates LGTM. |
BYK
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In getsentry/action-prepare-release#4, we unintentionally changed the format of the issue title.
publish: <repo>@<version>publish: <owner>/<repo>@<version>This is because the
GITHUB_REPOSITORYenv variable includes the full owner and repo name. There is also anGITHUB_REPOSITORY_OWNERvariable, but none that only contains the repo name. This means we have two options:In this PR, I'm going with option 2,
although it is not backwards compatible. This means we will have to change all existing actions before attempting the next release.