Skip to content

Add lines to mapbox static polygons#7090

Merged
seadowg merged 3 commits intogetodk:v2026.1.xfrom
grzesiek2010:COLLECT-7084
Feb 12, 2026
Merged

Add lines to mapbox static polygons#7090
seadowg merged 3 commits intogetodk:v2026.1.xfrom
grzesiek2010:COLLECT-7084

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 11, 2026 •
edited
Loading

Closes #7084

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss here. This is a continuation of the work started in #7069

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It’s an isolated change, so there’s no need to test other map providers besides Mapbox. It’s also limited to static polygons (non-editable ones used in select one from map). The polygons generated in the geoshape question (dynamic ones) were not touched here.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg February 11, 2026 22:05
@seadowg seadowg added needs testing high priority Should be looked at before other PRs/issues labels Feb 12, 2026
@seadowg seadowg merged commit f3e5fb5 into getodk:v2026.1.x Feb 12, 2026
8 checks passed
@dbemke
Copy link

dbemke commented Feb 13, 2026

Could you send us an apk? The one 2026.1.x hasn't compiled. The apk in the PR hasn't got the Mapbox token.

@seadowg
Copy link
Member

seadowg commented Feb 13, 2026

@dbemke I've approved that build! Sorry I thought I'd changed things so it wouldn't get blocked. I'll have another look.

@dbemke
Copy link

dbemke commented Feb 13, 2026

I've approved that build! Sorry I thought I'd changed things so it wouldn't get blocked. I'll have another look.

Thanks. The apk in 2026.1.x works well (there are map tokens).

@srujner
Copy link

srujner commented Feb 13, 2026

Hey I noticed two things here:

  1. When the line of polygon is thick the mapbox creates something that looks like a double line.
  2. There is missing "pixel" in the corner of some polygons

mapbox

mapbox2

Forms are in this project: https://test.getodk.cloud/projects/427/app-users user 1953
Forms: SelectOneFromMapMykonos and ValidStyling

@grzesiek2010
Copy link
Member Author

grzesiek2010 commented Feb 16, 2026 •
edited
Loading

I don’t think it’s worth investigating as part of v2026.1, but please feel free to file a separate issue so we’re aware of it.
I assume it was the same case for dynamic polygons that we handled in #7069, but you probably didn't spot it?
Is the missing pixel only visible when the polygon has a right angle?
It would be good to add those details when you file an issue.

@dbemke
Copy link

dbemke commented Feb 16, 2026

Tested with Success!

Verified on a device with Android 10

Verified cases:

  • lines in shapes in select one from map on Mapbox
  • map styling in select one from map checking the width, color etc.
  • regression checks in select one from map styling (points, traces, shapes), geoshape with incremental feature
  • shapes in select on from map and offline layers
  • quick regression checks in geo widgets

@WKobus
Copy link

WKobus commented Feb 16, 2026

Tested with Success!

Verified on a device with Android 16

@srujner
Copy link

srujner commented Feb 16, 2026

Tested with Success!

Verified on a device with Android 14

seadowg added a commit to seadowg/collect that referenced this pull request Feb 17, 2026
@seadowg
Merge pull request getodk#7090 from grzesiek2010/COLLECT-7084
f462c69 
Add lines to mapbox static polygons
@seadowg seadowg mentioned this pull request Feb 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seadowg seadowg seadowg approved these changes

Assignees

No one assigned

Labels

behavior verified high priority Should be looked at before other PRs/issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@grzesiek2010 @dbemke @seadowg @srujner @WKobus