Add lines to Mapbox polygons#7069
Merged
grzesiek2010 merged 1 commit intogetodk:v2026.1.xfrom Feb 3, 2026
Merged
Conversation
grzesiek2010
approved these changes
Feb 3, 2026
Member
|
@seadowg should we file a separate issue to display lines for static polygons as well? I mean those that can be selected, for example, in a 'Select One from Map' question. |
|
@grzesiek2010 I wanted to download the apk but it seems something went wrong - "Pending - Your job is on hold on CircleCI!" https://github.com/getodk/collect/commits/v2026.1.x |
Member
Author
|
@dbemke that's running now! |
|
Tested with Success! Verified on Android 10 Verified cases:
|
|
Tested with Success! Verified on Android 12 |
|
Tested with success Verified on Android 16 |
seadowg
pushed a commit
to seadowg/collect
that referenced
this pull request
Feb 10, 2026
Add lines to Mapbox polygons
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapbox geoshapes were showing without lines (just fill). This adds lines!
Why is this the best possible solution? Were any other approaches considered?
Nothing to discuss.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Only Mapbox is affected.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest