Use custom namespace for asio to prevent UE collision#418
Merged
getnamo merged 2 commits intogetnamo:masterfrom May 7, 2024
Merged
Use custom namespace for asio to prevent UE collision#418getnamo merged 2 commits intogetnamo:masterfrom
getnamo merged 2 commits intogetnamo:masterfrom
Conversation
Owner
|
Good idea for interoping with other plugins in unreal. I went ahead and merged the submodule changes. Update this PR to include the submodule ref updates and I'll merge it. |
Contributor
Author
|
Ok @getnamo, this PR is now ready |
Owner
|
I merged this, go ahead and check the master branch didn't have any regressions. Will do sanity checks on this merge later when I do a 5.4 release. |
Contributor
Author
|
I've been testing these changes in 5.3.2 for a month now and haven't had any issues with the features I use. My project is in the middle of a refactor so I can't test it with 5.4.1 yet; might take me a day or two to get to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #404 by renaming the
asionamespace toasio_sockioas well as any global functions in the asio library.This PR is dependent on these PRs:
This currently PR does not update the submodules as it didn't make sense to make a PR that referenced downstream repos temporarily until the dependent PRs are merged into the upstream repos. I can update this PR to have the updated submodules once those other PRs are merged, but you can also merge beforehand and update the submodules yourself if you'd prefer.
If you want to test these changes, the easiest way is to test the forked
redwoodbranch from https://github.com/redwoodmmo/SocketIOClient-Unreal/ which resembles the final merged state (other than a change to the plugin's engine version)