Closed
Conversation
Contributor
|
Change looks simple enough for a merge. I don't see any major issues that would prevent this from being merged. It may be a good idea to prep this again with the mainline to ensure that it is able to be merged without issues. It has been 9 months since the last force-push. (I say this despite Github saying no conflicts with the base branch. Just a suggested fail-safe.) LGTM |
Contributor
|
Hello @snhobbs ! Thank you for the patch. |
Contributor
|
I will close this and open a new PR with a new branch addressing this, hopefully keeping the correct authors. |
spe-ciellt
added a commit
that referenced
this pull request
Feb 27, 2026
* adding dxf export to command line tool Cherry-picked from PR #228 (0a4e276), rebased onto develop. Conflicts resolved: removed #ifndef ENABLE_DXF stub (function already exists in export-dxf.cpp), adapted to develop's coding style and existing --svg-layers help text. * fix: guard DXF export in main.c with HAVE_LIBDXFLIB When dxflib is not installed, export-dxf.cpp is not compiled and gerbv_export_dxf_file_from_image() is undefined. Guard all DXF references in main.c (enum, name arrays, switch cases, help text) with #ifdef HAVE_LIBDXFLIB to fix the linker error on systems without dxflib. --------- Co-authored-by: simon <simon.hobbs@electrooptical.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dxf image export to the CLI. To maintain the --enable-dxf option I added a definition flag and a ifndef block in main.c. The stub in main.c will just complain about not actually being enabled.
PR for issue #227