Merged
Conversation
When dxflib is not installed, export-dxf.cpp is not compiled and gerbv_export_dxf_file_from_image() is undefined. Guard all DXF references in main.c (enum, name arrays, switch cases, help text) with #ifdef HAVE_LIBDXFLIB to fix the linker error on systems without dxflib. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #228 by @snhobbs, rebased onto
developwith conflict resolution. Based on #228Closes #227.
Adds
--export=dxfto the CLI. Callsgerbv_export_dxf_file_from_image()(already present inexport-dxf.cpp). The#ifndef ENABLE_DXFstub was dropped — DXF export is always available.Original commit by Simon Hobbs (@snhobbs), 2023-11-24, preserved in git history.
Co-authored-by: snhobbs simon.hobbs@electrooptical.net