Skip to content

#9683: add Details Panel for MS dashboard [adding missing plugins in sidebar menu]#9730

Merged
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:fix_feature_9683
Nov 22, 2023
Merged

#9683: add Details Panel for MS dashboard [adding missing plugins in sidebar menu]#9730
MV88 merged 1 commit intogeosolutions-it:masterfrom
mahmoudadel54:fix_feature_9683

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

  • Adding the missing plugins: export, import, delete dashboard
  • Reorder shown plugins in sidebar for dashboard

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9683

What is the current behavior?
#9683

What is the new behavior?
Sidebar menu in dashboard page now includes the missing plugins (Export, Import, Delete Dashbaord)

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.00 milestone Nov 22, 2023
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 22, 2023 16:02
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 22, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Nov 22, 2023 that may be closed by this pull request
3 tasks
@MV88 MV88 merged commit 0956266 into geosolutions-it:master Nov 22, 2023
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Nov 22, 2023

@ElenaGallo please test it in DEV

@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 24, 2023
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Nov 24, 2023

this has to be backported in c040-2023.02.xx

MV88 pushed a commit to MV88/MapStore2 that referenced this pull request Nov 24, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 27, 2023
- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard
@mahmoudadel54
Copy link
Copy Markdown
Contributor Author

this has to be backported in c040-2023.02.xx

Backport is done --- > #9750

tdipisa pushed a commit that referenced this pull request Nov 27, 2023
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <diegodevelopero@gmail.com>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
Co-authored-by: Diego Vargas <diegodevelopero@gmail.com>
Co-authored-by: Suren <dsuren1@gmail.com>
Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C040-COMUNE_GE-2023-CUSTOM-SUPPORT New Feature used for new functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details panel for MS dashboards

2 participants