#9567: handle functionality of zoom to record in table widgets by mahmoudadel54 · Pull Request #9608 · geosolutions-it/MapStore2

mahmoudadel54 · 2023-10-16T15:38:08Z

Description

Handle functionality of zoom to record in table widgets [Map, Dashboard]

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Issue

#9567

What is the current behavior?
#9567

What is the new behavior?
a zoom icon is added on the left side of each record to allow the zoom operation:

to the related layer feature the table widget is referring to (in case of map viewer)
to the related feature extent in the map widget the table widget is connected to (in case of dashboards)

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

Yes, and I documented them in migration notes
No

Other useful information

… widgets

…ts (geosolutions-it#9567) This commit addresses the failing test cases related to the issue of zoom records in table widgets.

MV88

Hi, functionality wise is good, and works. but i asked clarifications to @tdipisa and we have now specified some more details in the issue. please check them and let me know if you have doubts

web/client/components/widgets/enhancers/dependenciesToZoomTo.js

…n table widgets + writing unit tests

…e zoom icon for tblWidget

… dashboard and map viewer

MV88

@tdipisa i think it's worth to have also @offtherailz reviewing this given the latest changes

web/client/configs/localConfig.json

web/client/components/widgets/builder/wizard/table/TableOptions.jsx

web/client/components/widgets/enhancers/__tests__/dependenciesToExtent-test.jsx

web/client/components/widgets/enhancers/__tests__/dependenciesToZoomTo-test.jsx

web/client/components/widgets/widget/enhancedWidgets.js

web/client/selectors/widgets.js

web/client/components/widgets/enhancers/dependenciesToZoomTo.js

- put flag of zoomInTblWidget as a default prop - add translations - edit zoomToExtent enhancer to use internal zoom - remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead -

MV88

a few changes but we are close.
I just checked the codebase and I'll do a test of the functionality after that the comments will be fixed. looking promising anyway

web/client/components/widgets/widget/enhancedWidgets.js

web/client/configs/localConfig.json

web/client/plugins/Widgets.jsx

web/client/translations/data.it-IT.json

MV88

in some cases the zoom to button is superfluous in the dashboard

create a single table widget

following point 1

create a table widget
create a map widget and connect it to the table, so that the table drives the map widget viewport

@tdipisa do we want this to be done inside this PR or not ?

web/client/configs/localConfig.json

MV88 · 2023-11-08T15:06:28Z

@tdipisa do we want this to be done inside this PR or not ?

@mahmoudadel54 with @tdipisa we agreed to take care also for this point notified above
so please proceed

MV88

LGTM

MV88 · 2023-11-10T16:58:05Z

@ElenaGallo please test it in DEV

ElenaGallo · 2023-11-13T11:13:40Z

@tdipisa @mahmoudadel54 some notes after my tests:

1_ It is not clear what feature the zoom highlights

map.mp4

2_ The highlighted Zoom button is not the one for the feature you zoomed on

map_2.mp4

3_ On Dashboard, when a Table is added before the map, the zoom buttons are not visible on the Table widget.

dash.mp4

MV88 · 2023-11-14T10:41:03Z

all the points above are not an issue.

points 1 and 2

in here the feature zoomed is centered in the map viewer and since you have some widgets covering it you can partially miss it.
I'm not sure we have to apply a highlight effect that would need a manual procedure to hide
@tdipisa any feedback here? I think we could ignore this for now

point 3

not an issue. It shows up only when a table (child widget) is connected to a map (parent widget) or
better when the table depends on map viewport

tdipisa · 2023-11-14T16:18:49Z

@tdipisa any feedback here? I think we could ignore this for now

Nothing to do for now. Thank you

Up to you to move in done with accepted label @ElenaGallo

MV88 · 2023-11-24T16:35:46Z

this has to be backported in c040-2023.02.xx

… widgets (geosolutions-it#9608) * geosolutions-it#9567: handle functionality of zoom to record in table widgets * Fix: Correct failing test cases for zoom records issue in table widgets (geosolutions-it#9567) This commit addresses the failing test cases related to the issue of zoom records in table widgets. * geosolutions-it#9567: implement the new approach in zoom to records in table widgets + writing unit tests * geosolutions-it#9567: handle adding flag into config file to show/hide zoom icon for tblWidget * geosolutions-it#9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer * geosolutions-it#9567: resolve comments' review: - put flag of zoomInTblWidget as a default prop - add translations - edit zoomToExtent enhancer to use internal zoom - remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

mahmoudadel54 · 2023-11-27T08:23:34Z

this has to be backported in c040-2023.02.xx

Backport is Done ---> #9749

* Fix #9624 Point cloud shading options (#9666) * Fix #9666 Include pointCloudShading option to saved layer config (#9670) * #9606 Error with circle annotations + radius selection (#9607) (#9727) Co-authored-by: Diego Vargas <diegodevelopero@gmail.com> * Fix #9295 added better handling of format in csw service (#9712) (#9732) * #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744) * #9567: handle functionality of zoom to record in table widgets (#9608) * #9567: handle functionality of zoom to record in table widgets * Fix: Correct failing test cases for zoom records issue in table widgets (#9567) This commit addresses the failing test cases related to the issue of zoom records in table widgets. * #9567: implement the new approach in zoom to records in table widgets + writing unit tests * #9567: handle adding flag into config file to show/hide zoom icon for tblWidget * #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer * #9567: resolve comments' review: - put flag of zoomInTblWidget as a default prop - add translations - edit zoomToExtent enhancer to use internal zoom - remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead * #9683: add Details Panel for MS dashboard (#9689) * #9683: add Details Panel for MS dashboard - The tool have the same options (eg. show as modal, show at startup etc.) - The tool is defined in the same way of the corresponding one for maps. - Edit the layout to put add widget & show/hide connection buttons to the sidebar menu * #9683: resolve the FE test Update DashboardEditor.jsx * #9683: resolve review comments * description: - remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard. - add missing test for detailsLoaded action - create new selectors, details uri selector and details settings se;ector that are used in many places in code - move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder - Put global spinner in details plugin and remove it from sidebar plugin - edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard - Add custom style in details.less as the lib of react-dock doesn't allow to override left css property - remove unused added style from panels.less * #9683: remove unused comments in dashboard-test file * #9683: edit in details epics and selectors to fix FE test * #9683: Resolve review comments Description: - Reolve unused loading property from DashoardEditor file - Add tooltip for save dashboard - Remove custom style in BorderLayout and leave it with generic style * #9683: resolve review comments Description: - edit navbar.less files to fix going language selector behind body panel - remove unused z-index in dashboard.less # Conflicts: # web/client/epics/__tests__/config-test.js # web/client/epics/config.js * #9683: resolve test comment (#9730) - Adding export, import, delete dashboard - Reorder shown plugins in sidebar for dashboard * #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title] (#9740) * #9683: resolve test comment Description: - edit the detail panel tooltip and shown title and make it generic one - Add translations for the new tooltip * Update web/client/translations/data.it-IT.json --------- Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com> * #9728 fix misalignement issue (#9731) (#9742) * Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747) --------- Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com> Co-authored-by: Diego Vargas <diegodevelopero@gmail.com> Co-authored-by: Suren <dsuren1@gmail.com> Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>

geosolutions-it#9567: handle functionality of zoom to record in table…

90ba37c

… widgets

mahmoudadel54 added enhancement C040-COMUNE_GE-2023-CUSTOM-SUPPORT labels Oct 16, 2023

mahmoudadel54 added this to the 2024.01.00 milestone Oct 16, 2023

mahmoudadel54 requested a review from MV88 October 16, 2023 15:38

mahmoudadel54 self-assigned this Oct 16, 2023

mahmoudadel54 linked an issue Oct 16, 2023 that may be closed by this pull request

Zoom to record in table widgets #9567

Closed

12 tasks

Fix: Correct failing test cases for zoom records issue in table widge…

6b2667d

…ts (geosolutions-it#9567) This commit addresses the failing test cases related to the issue of zoom records in table widgets.

MV88 requested changes Oct 20, 2023

View reviewed changes

geosolutions-it#9567: implement the new approach in zoom to records i…

73d51f8

…n table widgets + writing unit tests

mahmoudadel54 requested a review from MV88 October 25, 2023 08:43

mahmoudadel54 added 2 commits October 25, 2023 14:01

geosolutions-it#9567: handle adding flag into config file to show/hid…

d726313

…e zoom icon for tblWidget

geosolutions-it#9567: reset flag enableZoomInTblWidget to be true for…

16b1eef

… dashboard and map viewer

MV88 requested changes Oct 30, 2023

View reviewed changes

geosolutions-it#9567: resolve comments' review:

9d8beee

- put flag of zoomInTblWidget as a default prop - add translations - edit zoomToExtent enhancer to use internal zoom - remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead -

mahmoudadel54 requested review from MV88, offtherailz and tdipisa October 31, 2023 23:12

tdipisa removed request for offtherailz and tdipisa November 3, 2023 09:35

MV88 requested changes Nov 3, 2023

View reviewed changes

geosolutions-it#9567: resolve review comments

0d9a5a0

mahmoudadel54 requested a review from MV88 November 6, 2023 10:20

MV88 requested changes Nov 7, 2023

View reviewed changes

web/client/configs/localConfig.json Show resolved Hide resolved

web/client/configs/localConfig.json Show resolved Hide resolved

geosolutions-it#9567: resolve comments' review

84642c1

mahmoudadel54 requested a review from MV88 November 9, 2023 09:16

MV88 approved these changes Nov 10, 2023

View reviewed changes

MV88 merged commit 2c89454 into geosolutions-it:master Nov 10, 2023

MV88 mentioned this pull request Nov 14, 2023

Fix #9622 adjusted rowHeight usage #9700

Merged

12 tasks

MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 24, 2023

mahmoudadel54 mentioned this pull request Nov 27, 2023

[Backport C040-2023.02.xx] #9567: handle functionality of zoom to record in table widgets (#9608) #9749

Closed

ElenaGallo mentioned this pull request Dec 14, 2023

#9783: implement zoom to record for parent table in dashboards #9787

Merged

12 tasks

allyoucanmap mentioned this pull request Oct 24, 2025

Refactor of widgets dependencies system #11627

Open

6 tasks

Conversation

mahmoudadel54 commented Oct 16, 2023

Description

Issue

Breaking change

Other useful information

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MV88 commented Nov 8, 2023

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

MV88 commented Nov 10, 2023

Uh oh!

ElenaGallo commented Nov 13, 2023

Uh oh!

MV88 commented Nov 14, 2023

Uh oh!

tdipisa commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MV88 commented Nov 24, 2023

Uh oh!

mahmoudadel54 commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tdipisa commented Nov 14, 2023 •

edited

Loading