Skip to content

Fix 4090 random failure of getFeatureInfoOnFeatureInfoClick WMS test#4091

Merged
offtherailz merged 1 commit intogeosolutions-it:masterfrom
MV88:fix_random_fail_test_GFI
Aug 14, 2019
Merged

Fix 4090 random failure of getFeatureInfoOnFeatureInfoClick WMS test#4091
offtherailz merged 1 commit intogeosolutions-it:masterfrom
MV88:fix_random_fail_test_GFI

Conversation

@MV88
Copy link
Copy Markdown
Contributor

@MV88 MV88 commented Aug 14, 2019

Description

Fix a random failure of a getFeatureInfoOnFeatureInfoClick WMS test

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix for a test

What is the current behavior? (You can also link to an open issue here)
test fails because it does not check that order can be different from time to time

What is the new behavior?
test checks that order can be different from time to time

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@MV88 MV88 requested a review from offtherailz August 14, 2019 08:46
@MV88 MV88 self-assigned this Aug 14, 2019
@offtherailz offtherailz merged commit 7e5deeb into geosolutions-it:master Aug 14, 2019
MV88 added a commit to MV88/MapStore2 that referenced this pull request Aug 14, 2019
…olutions-it#4091)

# Conflicts:
#	web/client/epics/__tests__/identify-test.js
MV88 added a commit that referenced this pull request Aug 20, 2019
… (#4092)

* Fixed issues due to sameURL check in #4004 (#4013)

* Fix random failure of getFeatureInfoOnFeatureInfoClick WMS test (#4091)
# Conflicts:
#	web/client/epics/__tests__/identify-test.js
* removed conflicts
* restored old tests to align the with the current code in 2019.02.xx
@MV88 MV88 added this to the 2019.02.02 milestone Aug 27, 2019
@tdipisa tdipisa modified the milestones: 2019.02.02, 2019.02.01 Sep 3, 2019
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Sep 3, 2019

@MV88 do we still need to backport this to the 2019.02.xx branch?

MV88 added a commit to MV88/MapStore2 that referenced this pull request Sep 3, 2019
…olutions-it#4091)

# Conflicts:
#	web/client/epics/__tests__/identify-test.js
MV88 added a commit that referenced this pull request Sep 5, 2019
…foOnFeatureInfoClick WMS test (#4140)

* Fix random failure of getFeatureInfoOnFeatureInfoClick WMS test (#4091)


# Conflicts:
#	web/client/epics/__tests__/identify-test.js

* removed a test for a code that was not present
offtherailz pushed a commit that referenced this pull request Sep 6, 2019
* Geostory scheleton (#4014)

* Geostory sections (#4029)

Add base structure for geostory scroll handlers and background setup (base support for immersive or cover backgrounds) .

* Geostory base text editing and content wrapper (#4033)

* Fix #9 Contents - Image (#4038)

* Geostory scroll immersive (#4044)

* Fix #69 Builder - Section Editor - Section selector - Title (#4063)

* Geostory add Section (#4078)

* Fix random failure of getFeatureInfoOnFeatureInfoClick WMS test (#4091) (#4099)

* Fix issue 78 Load story configuration (C039_geostory) (#4096)

* Fix issue 78 Load story configuration

* removed unneeded action in epic stream
* removed unneeded comment
* skip failing test

* Fix issue 62 Media Editor - Image  (C039_geostory) (#4101)

* First version of media editor (missing tests)
* Adding tests and documentation
* adding modify logic for media image with tests
* mediaEditor closed by default
* update node version to 8.6.0 in .travis.yml
* skip failing test for the moment

* Geostory - Normal editor - Title  (C039_geostory) (#4102)

* Fix issue 75,71 added content toolbar everywhere and media editor and media section (C039_geostory) (#4107)

* Fix Background content toolbar (C039_geostory)

* it contains also tests

* added editing for media and correct update of resource id

* also restructured the sample story for new layout of paragraph
* adding media toolbar on every Image

* missed one test in prevois commit

* Adding Media Section for GeoStory

* issue 71

* add some styles for immersive layout

* Removed section typemedia

* Fixed missing parts of SectionTemplate removals

* Fixed styles and minor changes

* fix add button position in geostory column content

* Fix media section toolbar as paragraph

* removed .only in tests

* Add column and immersive tests

* revert error commit

* revert error commit

* Fixed immersive tests

* Fixed column test

* Add remove button for images and immersive background

* Fixed remove buttons

* improve style of cascade layout

* Fixed array remove

* * removed path geostory
* image placeholder

* fix tests

* Add default resources for newgeostory

fix edit for empty background

* fix scrollbar in media editor

* Add remove to text. Add recursive conainer removal

* add tests for column and actions and content toolbars

* resotred tests.webpack.js changes committed in error

* removed temp comment

* update toolbar position and patterns

* fix failing epic test

* fix edit media for media inside immersive columns

* Add auto scroll for new content

* fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants